Repository navigation
benchmarking: what to set and watch before a dense run - #2499
Merged
Max Smythe (maxsmythe) merged 3 commits intoOct 28, 2026
Merged
Conversation
Davanum Srinivas (dims)
marked this pull request as ready for review
October 12, 2026 15:15
Davanum Srinivas (dims)
force-pushed
the
benchmarking-readme-scale
branch
2 times, most recently
from
October 14, 2026 00:42
0cc3c75 to
067bce6
Compare
Collaborator
|
Thank you for this! Have a couple of questions for clarity, although the general idea of a scaling guide is a good one. haiyanmeng you may find this interesting. |
Max Smythe (maxsmythe)
self-requested a review
October 14, 2026 05:27
Max Smythe (maxsmythe)
added
kind/docs
haiyanmeng
self-requested a review
October 14, 2026 12:46
haiyanmeng
reviewed
Oct 14, 2026
haiyanmeng
left a comment
haiyanmeng
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the contribution.
May I ask how did you identify these best practices? Did you encounter these bottlenecks while running the benchmark tests in a dense mode?
Davanum Srinivas (dims)
force-pushed
the
benchmarking-readme-scale
branch
from
October 14, 2026 15:55
067bce6 to
30955cc
Compare
Collaborator
Author
Yes, exactly what i did haiyanmeng some of what i did i am slowly pushing to https://github.com/dims/gym-substrate FYI |
Max Smythe (maxsmythe)
requested changes
Oct 14, 2026
Max Smythe (maxsmythe)
left a comment
Max Smythe (maxsmythe)
left a comment
Collaborator
There was a problem hiding this comment.
Added comments... forgot that they were in draft mode.
Collaborator
Author
|
closing and reopening to re-trigger a flaky ci test |
Davanum Srinivas (dims)
force-pushed
the
benchmarking-readme-scale
branch
8 times, most recently
from
October 22, 2026 12:35
d134a37 to
8b20fa5
Compare
Davanum Srinivas (dims)
force-pushed
the
benchmarking-readme-scale
branch
3 times, most recently
from
October 23, 2026 15:48
808afb7 to
572a5d5
Compare
Max Smythe (maxsmythe)
approved these changes
Oct 24, 2026
Max Smythe (maxsmythe)
left a comment
Max Smythe (maxsmythe)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thank you for this!
Giving haiyanmeng a chance for any follow up comments before merging.
Davanum Srinivas (dims)
force-pushed
the
benchmarking-readme-scale
branch
2 times, most recently
from
October 26, 2026 15:20
bee26e9 to
b78308d
Compare
Limits a dense run meets that the demo path never reaches: port-forward under load, PostgreSQL slots and probes, the parking budget, synchronized bursts, the neighbor table, restores under full load, the kubelet. Signed-off-by: Davanum Srinivas <[email protected]>
The pool flag has no default of 20: unset, pgx sizes the pool at the node CPU count. The port-forward point applies only to a load generator outside the cluster. Only the liveness probe restarts postgres. Signed-off-by: Davanum Srinivas <[email protected]>
Name the oversubscription behind "2x", say headroom rather than steering restores (Substrate has no such control), and spell out that the postgres probe fix includes the container resource requests. Signed-off-by: Davanum Srinivas <[email protected]>
Davanum Srinivas (dims)
force-pushed
the
benchmarking-readme-scale
branch
from
October 27, 2026 12:23
b78308d to
72a84c8
Compare
Collaborator
|
Merging... doc only change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dense run meets limits the demo path never reaches. One new section lists them with the setting for each: reaching the API and router without
kubectl port-forward, PostgreSQL slots and probe timeouts, the parking budget, synchronized bursts against the ext_proc breaker, the kernel neighbor table, restores under full load, kubelet CPU reservation, and what to watch during the run.Docs only.