Repository navigation
ateinterceptors: elide List responses from the RPC log - #2494
Merged
Merged
Conversation
Davanum Srinivas (dims)
marked this pull request as ready for review
October 12, 2026 13:52
Davanum Srinivas (dims)
force-pushed
the
ateapi-list-log
branch
2 times, most recently
from
October 14, 2026 00:48
a28dc7c to
19ac900
Compare
Benjamin Elder (BenTheElder)
left a comment
Benjamin Elder (BenTheElder)
left a comment
Collaborator
There was a problem hiding this comment.
generally LGTM, one agent catch
Davanum Srinivas (dims)
force-pushed
the
ateapi-list-log
branch
3 times, most recently
from
October 17, 2026 01:39
795d272 to
de5bc57
Compare
Collaborator
A page of a thousand actors is tens of kilobytes per call. At scale those pages rotated the lifecycle lines out of the container log in minutes. Log the response size instead.
The generated handlers return a typed nil on error, which the elision turned into "<ListActors response elided, 0 bytes>" instead of null.
Davanum Srinivas (dims)
force-pushed
the
ateapi-list-log
branch
from
October 18, 2026 21:04
de5bc57 to
e95aed5
Compare
Bowei Du (bowei)
added
area/api-machinery
area/observability
kind/bug
Haven Xia (HavenXia)
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RPC log line carries the whole response; a List page of a thousand actors is tens of kilobytes and rotates the lifecycle lines out of the container log.
List*responses are logged as<ListActors response elided, N bytes>; the response to the client is untouched.Listcall logs the handler'snull, not an elided placeholder.go test -race ./internal/ateinterceptors/, lint clean.