Repository navigation
setup-gcp no longer disables Filestore on an existing cluster - #2485
Merged
Michelle Au (msau42) merged 4 commits intoOct 19, 2026
Merged
Michelle Au (msau42) merged 4 commits into
Michelle Au (msau42) merged 4 commits into
Conversation
Contributor
Author
|
Michelle Au (@msau42) Bowei Du (@bowei) PTAL when you get a chance. Thank you! |
Michelle Au (msau42)
previously approved these changes
Oct 16, 2026
Michelle Au (msau42)
enabled auto-merge
October 16, 2026 05:44
Collaborator
|
PR needs rebase to pick up the new e2e test |
Contributor
Author
|
Michelle Au (@msau42) Merged main. PTAL. |
# Conflicts: # tools/setup-gcp/cmd/cluster_test.go
auto-merge was automatically disabled
October 17, 2026 08:59
Head branch was pushed to by a user without write access
Contributor
Author
|
Michelle Au (@msau42) Merged main again. PTAL. |
Contributor
Author
|
Merged main. PTAL Michelle Au (@msau42). |
Bowei Du (bowei)
added
area/dev-infra
area/storage
kind/bug
Michelle Au (msau42)
approved these changes
Oct 19, 2026
Michelle Au (msau42)
enabled auto-merge
October 19, 2026 19:45
Steven Shriver (stshrive)
added a commit
to stshrive/substrate-gke
that referenced
this pull request
Oct 26, 2026
Pulls in the change that stops setup-gcp disabling the Filestore add-on on an existing cluster from [Agent Substrate PR 2485](agent-substrate/substrate#2485). setup-gcp matches upstream. The installer warned about the old behavior (ai-on-gke#53), so it changes too: - Provision no longer warns that bootstrap turns off GKE's managed Filestore CSI driver. - The optional Filestore step still turns the managed driver off before installing Substrate's (DeployFilestoreCSI is unchanged). On an existing cluster with the driver on, it now warns that installing does this and that skipping keeps the managed driver. - The tools/setup-gcp README also drops Filestore from the settings it updates in place on an existing cluster.
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bootstrap no longer turns off the Filestore add-on on a cluster it did not create. Clusters it creates still start with it off.
Fixes #2357