Repository navigation
ateapi: carry the golden actor's crash detail into template failures - #2453
Closed
Ziyi Tan (Ziy1-Tan) wants to merge 1 commit into
Closed
Ziyi Tan (Ziy1-Tan) wants to merge 1 commit into
Ziyi Tan (Ziy1-Tan) wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@google-cla-bot recheck |
1 similar comment
Author
|
@google-cla-bot recheck |
The golden actor's Status.Crash.message names the operation and the underlying error (e.g. an atelet RPC failure) that moved the actor to CRASHED, but the reconciler replaced it with a static string, so the only user-visible signal was "golden actor crashed before its snapshot was taken" and the actual cause stayed buried in worker pod logs. Join the crash message into the template's failure message (every write path that sets CRASHED records one), and name the conflicting owner in the golden tag conflict failure instead of a generic string.
Ziyi Tan (Ziy1-Tan)
force-pushed
the
golden-failure-detail
branch
from
October 10, 2026 15:20
dd18933 to
e273731
Compare
2 tasks done
Bowei Du (bowei)
added
area/api-machinery
kind/feature
Collaborator
|
overlaps with #2644 ok to go with that one? |
Anna Pendleton (annapendleton)
pushed a commit
to annapendleton/substrate
that referenced
this pull request
Oct 28, 2026
…us (agent-substrate#2644) When the actor used to build a template crashes, the template status now includes the actor's crash message. This makes failures such as a bad image volume or failed restore visible directly on the template. Overlaps with agent-substrate#2453, which also adds crash details to template failures. - [x] Tests pass: `go test -race ./cmd/ateapi/internal/controlapi/`; `go vet`. - [x] Appropriate changes to documentation are included in the PR: none needed. Signed-off-by: Davanum Srinivas <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Joins the crashed golden actor's
Status.Crash.messageinto the template's failure message, and names the conflicting owner in the golden tag conflict failure instead of a generic string.The golden actor's crash record names the operation and the underlying error (e.g. an atelet RPC failure), but the reconciler replaced it with a static string, so a user whose template fails only sees the generic
golden actor crashed before its snapshot was takenand has to dig through worker pod logs for the actual cause. Every write path that setsACTOR_STATE_CRASHEDrecords a crash message, so it is joined unconditionally:The golden tag conflict failure now reports the conflicting owner (template UID, source actor) instead of the generic string.
TestReconcileOne_GoldenTagConflict's exact-match subtests are updated to expect the owner-identifying message, and the crashed-actor case now asserts the crash detail lands inErrorMessageend to end.Message length stays bounded:
fail()truncates atmaxGoldenErrorMessageLen, andActorCrash.messageis itself capped at 4096 bytes.Tests pass (
go test ./cmd/ateapi/...)Docs: n/a