Repository navigation
Rename the object-store plugin proto package to objectstore.v1 - #2432
Merged
Haven Xia (HavenXia) merged 1 commit intoOct 9, 2026
Merged
Haven Xia (HavenXia) merged 1 commit into
Haven Xia (HavenXia) merged 1 commit into
Conversation
Anish Ramasekar (aramase)
force-pushed
the
aramase/c/objectstore_proto_rename
branch
from
October 9, 2026 21:24
cb7e9f6 to
fa77acf
Compare
Collaborator
Author
|
cc ILLUM1N0X Haven Xia (@HavenXia) the CI is failing because of docker rate limit. Could you rerun the CI? |
Anish Ramasekar (aramase)
marked this pull request as ready for review
October 9, 2026 21:36
ILLUM1N0X
approved these changes
Oct 9, 2026
Haven Xia (HavenXia)
enabled auto-merge
October 9, 2026 21:58
Haven Xia (HavenXia)
approved these changes
Oct 9, 2026
Member
rerunning, will merge when they passed |
Merged
via the queue into
agent-substrate:main
with commit Oct 9, 2026
85b128a
15 of 18 checks passed
Anish Ramasekar (aramase)
deleted the
aramase/c/objectstore_proto_rename
branch
October 9, 2026 23:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the object-store plugin proto package from
objectstoresnapshot.v1toobjectstore.v1. It is split out of #2385 as its own refactor, since that PR adds a non-snapshot service to the same API.pkg/proto/objectstoresnapshotpb/v1topkg/proto/objectstorepb/v1andobjectstoresnapshot.prototoobjectstore.proto, regenerated withhack/update/codegen.sh.docs/architecture.md.cmd/snapshot-pluginbinary, image and manifests are unchanged.Open #1907 will need a rebase. It adds no references to the old package, so only its existing conflicts with main apply.
Breaking change
gRPC method names change from
/objectstoresnapshot.v1.<Service>/<Method>to/objectstore.v1.<Service>/<Method>. Out-of-tree plugins must regenerate fromobjectstore.protoand roll out with atelet and ate-api-server. Please add thebreaking-changelabel.