Repository navigation
Router authn/z part 2.5: podcertcontroller: Don't load pod in podidentity signer - #2389
Merged
Lior Lieberman (LiorLieberman) merged 1 commit intoOct 15, 2026
Conversation
Taahir Ahmed (ahmedtd)
requested review from
Eitan Yarmush (EItanya) and
Lior Lieberman (LiorLieberman)
October 9, 2026 04:18
Taahir Ahmed (ahmedtd)
changed the title
Collaborator
|
Taahir Ahmed (@ahmedtd), is seems like the core function of this PR is actually the downstream mTLS changes to ingress. Can we update the description/purpose accordingly? Edit: I see this is stacked? |
Taahir Ahmed (ahmedtd)
marked this pull request as draft
October 9, 2026 23:20
Collaborator
Author
Yes, this is stacked. I switched it to draft mode to make it clearer |
Taahir Ahmed (ahmedtd)
force-pushed
the
router-authnz-2.5
branch
from
October 13, 2026 23:38
b83aa1c to
6ec8206
Compare
Taahir Ahmed (ahmedtd)
marked this pull request as ready for review
October 13, 2026 23:38
Collaborator
Author
|
OK, this is now unstacked and ready for review. |
Taahir Ahmed (ahmedtd)
requested review from
Eitan Yarmush (EItanya) and
Lior Lieberman (LiorLieberman)
and removed request for
Eitan Yarmush (EItanya) and
Lior Lieberman (LiorLieberman)
October 13, 2026 23:38
Bowei Du (bowei)
added
area/network
area/security
Lior Lieberman (LiorLieberman)
approved these changes
Oct 15, 2026
We should rely on the checks enforced by kube-apiserver. We don't need to double-check whether the pod exists. Upcoming e2e test changes will rely on the fact that non-Kubelet clients are allowed to create arbitary PodCertificateRequests, even if the pod or service account they reference does not exist.
Lior Lieberman (LiorLieberman)
force-pushed
the
router-authnz-2.5
branch
from
October 15, 2026 19:15
6ec8206 to
9298433
Compare
Lior Lieberman (LiorLieberman)
approved these changes
Oct 15, 2026
Lior Lieberman (LiorLieberman)
enabled auto-merge
October 15, 2026 19:17
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should rely on the checks enforced by kube-apiserver. We don't need to double-check whether the pod exists.
Upcoming e2e test changes will rely on the fact that non-Kubelet clients are allowed to create arbitary PodCertificateRequests, even if the pod or service account they reference does not exist. This will allow the test code running in Github Actions (or on the developer's machine) to authenticate to the router running within the cluster.