Repository navigation
Remove makefile - #2374
Remove makefile#2374
Conversation
|
github workflow is calling the junit tool via makefile |
Our entry points for building images and installing are the scripts under hack/ and cmd/ate-setup. Removing the Makefile cleans up a dev entrypoint we are no longer using. The primary functionality that still came from the Makefile was `make build-release-images`. This has been replaced by `cmd/ate-setup publish release-images`
4091b93 to
3cc2a90
Compare
Yes, I see. There was also make build-release-images. Claude to the rescue. |
|
Never mind, the successful runs were just hidden from the UI until I expanded it. |
Benjamin Elder (BenTheElder)
left a comment
Benjamin Elder (BenTheElder)
left a comment
There was a problem hiding this comment.
two things for follow-up.
approving but not enabling the merge queue, so it can be merged or these can be fixed at discretion.
| - **Release images**: `make build-release-images KO_DOCKER_REPO=REPO VERSION=TAG` (every image a pre-built install needs, all tagged `TAG`, including the docker-built `envoy-dataplane`; `make build-envoy-dataplane` builds only that one) | ||
| ### Building and Installing | ||
| - **Install from source**: `go run ./cmd/ate-setup deploy ate-system` (or the `hack/install-ate.sh` shim) builds every image with ko as part of the install; see `cmd/ate-setup/README.md` | ||
| - **Binaries**: `go build -o bin/kubectl-ate ./cmd/kubectl-ate`, `go build -o bin/ate-setup ./cmd/ate-setup` |
There was a problem hiding this comment.
These drop the ldflags that make build-atectl and make build-ate-setup passed.
Not blocking but we should probably have internal/version fall back to the module version.
There was a problem hiding this comment.
Added. Actually, it seems like everything is available from debug.ReadBuildInfo()? I might follow up to remove the ability for these to be externally stamped.
| if err != nil { | ||
| return err | ||
| } | ||
| envoy, err := images.PublishDockerfileImage(ctx, e.Cfg.Root, e.Cfg.KODockerRepo, envoyDataplaneImage, tag, |
There was a problem hiding this comment.
Not blocking: ko picks up defaultPlatforms (amd64 + arm64) from .ko.yaml, but envoy-dataplane falls back to amd64 only when KO_DEFAULTPLATFORMS is unset. So a default release is multi-arch except envoy.
We should probably fix that.
There was a problem hiding this comment.
Addressed. The build also reads the platforms .ko.yaml now.
Our entry points for building images and installing are the scripts under hack/ and cmd/ate-setup. Removing the Makefile cleans up a dev entrypoint we are no longer using.