Repository navigation
benchmarking: pace boomer to a target rate and add the resumepaused user class - #2350
Merged
Max Smythe (maxsmythe) merged 2 commits intoOct 13, 2026
Merged
Max Smythe (maxsmythe) merged 2 commits into
Max Smythe (maxsmythe) merged 2 commits into
Conversation
haiyanmeng
commented
Oct 8, 2026
haiyanmeng
force-pushed
the
boomer-load-generator
branch
3 times, most recently
from
October 8, 2026 19:06
7b2173d to
80ece49
Compare
haiyanmeng
force-pushed
the
boomer-load-generator
branch
from
October 11, 2026 21:09
80ece49 to
afc96d1
Compare
haiyanmeng
force-pushed
the
boomer-load-generator
branch
from
October 11, 2026 21:14
afc96d1 to
839e7f7
Compare
A capacity run holds each request rate for a step and reads the cost at that rate. Stepping users does not hold a rate: a closed-loop user sends its next request when the last one returns, so when the server slows the offered load drops with it. dynconfig gains target_rps, the requests per second a whole boomer worker paces to, for user classes that pace themselves; 0 means unpaced and a negative value is rejected. Like the other fields, the master can change it while the run continues. locust gains --target-rps to set it, and a --ladder step can end in @target_rps, e.g. 200:3m@4000, to change it as the step starts. boomer reads a rate-only change at its next poll of the master's config.
haiyanmeng
force-pushed
the
boomer-load-generator
branch
2 times, most recently
from
October 11, 2026 21:57
6ab42f1 to
b63f7e6
Compare
haiyanmeng
force-pushed
the
boomer-load-generator
branch
from
October 13, 2026 15:43
b63f7e6 to
e54598b
Compare
resumepaused drives ate-api-server's cold resume path at a set rate. Each user owns one actor. On its first iteration the user creates the actor from the glutton template and makes it cold with a resume and a pause; every later iteration resumes the actor and pauses it again. Boomer gives a task no user identity, so the actor is keyed by the user's goroutine ID, as in the glutton classes. The warm-up is not paced and is recorded under its own names, in the step that added the user. It adds load only while users join at the spawn rate, a stretch of each step that is trimmed anyway. An actor that fails to warm is deleted and the user tries again on its next iteration. Only the resume is paced, to dynconfig's target_rps, through one limiter the users share with a burst of 1, so resumes arrive evenly rather than in a burst at the start of each second. The target is therefore cold resumes per second. The pauses follow at the same rate, so a capacity the class finds is one of resume and pause cycles. A resume that finds its actor running fails the sample, as no cold resume happened. A failed cycle pauses the actor again so it is cold for the next one; that pause is recorded as PauseActorRecovery, apart from the measured pauses, and counts as a success when it finds the actor already paused. If the atespace cannot be ensured, the worker exits at startup. Shutdown waits for the cycles and setups in flight and deletes every actor. They get half of its time budget; any still running then are canceled, so a hung RPC cannot leave the deletes no time. Once shutdown begins, samples go to Prometheus only: boomer may have stopped draining its stats channel, and a send to it would block once the buffer fills. resumepaused sends the actors themselves no requests, so it runs on the fake data plane, where it measures what a cold resume costs ate-api-server and Postgres without the router or the restore in the way. benchmarking/README.md documents its knobs and metrics.
haiyanmeng
force-pushed
the
boomer-load-generator
branch
from
October 13, 2026 16:20
e54598b to
a05ff95
Compare
Max Smythe (maxsmythe)
approved these changes
Oct 13, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets boomer hold a fixed request rate for each ladder step, and adds a user class,
resumepaused, that drives ate-api-server's cold resume path at that rate. It is needed for ate-api-server capacity runs: a closed-loop user can't hold a rate, because the offered load drops whenever the server slows down. Benchmark-only, with no production code changes.Commits
target_rps, is set with--target-rpsor per ladder step asusers:duration@rps(e.g.200:3m@4000). Boomer picks up a change within 10 s. Only user classes that pace themselves honor it, which today is resumepaused.ResumeActorCold, paced totarget_rps) and pauses it again (PauseActor). The warm-up is unpaced and recorded under its own names (CreateActor,ResumeActorWarmup,PauseActorWarmup) in the step that added the user. Every actor is deleted on exit. It sends no traffic to the actors, so it runs on the fake data plane (fake-dataplane: let the fake data plane host actors #2300).Notes for reviewers
usersat or above the rate times the p99 cycle time, or a step falls short of its rate.target_rpspaces one boomer worker.tests.yamlcapacity tests come in a follow-up PR.Details are in the ResumePaused section of
benchmarking/README.md.Testing
go test -race ./internal/benchmarking/boomer/...python3 benchmarking/locust/unit_tests/test_ladder_shape.py(needs locust)python3 benchmarking/automation/test_orchestrator.pyAddresses #2261