Repository navigation
ate-setup: do not record demo and benchmark deploys - #2320
Merged
Tim Hockin (thockin) merged 1 commit intoOct 8, 2026
Merged
Conversation
Every successful deploy run replaced the cluster's install record with the settings that run was given. A demo or benchmark deploy runs on top of an installed system and is given only its own settings, so it left a record that no longer reproduces the install. After `deploy ate-system --credential-provider=...` and then `deploy demo counter`, the record no longer had the credential provider, and an upgrade that replays it fails at `deploy atenet`. The record annotation now takes "yes" or "no", and the nearest annotated command decides. `deploy demo` and `deploy benchmarks` opt out.
Steven Shriver (stshrive)
approved these changes
Oct 8, 2026
ILLUM1N0X
self-requested a review
October 8, 2026 02:39
ILLUM1N0X
approved these changes
Oct 8, 2026
Tim Hockin (thockin)
enabled auto-merge
October 8, 2026 03:00
Tim Hockin (thockin)
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every successful deploy run replaced the cluster's install record with the settings that run was given.
A demo or benchmark deploy runs on top of an installed system and is given only its own settings, so it left a record that no longer reproduces the install. For example, after
deploy ate-system --credential-provider=...and thendeploy demo counter, the record no longer had the credential provider, and an upgrade that replays it fails atdeploy atenet.The record annotation now takes "yes" or "no", and the nearest annotated command decides.
deploy demoanddeploy benchmarksopt out.Part of #1887 and it unblocks #1686