Repository navigation
Volume E2E tests wait for actor restoration before checking mounts - #2294
Merged
Max Smythe (maxsmythe) merged 1 commit intoOct 8, 2026
Conversation
The router parking budget can expire while a micro-VM is restoring on a busy node. Resume within the volume test deadline so mount and snapshot assertions do not depend on that shorter budget.
Luomu (cloudonly)
marked this pull request as ready for review
October 7, 2026 05:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The combined-volume E2E test wakes a suspended or reverted actor with its first HTTP probe. On a busy micro-VM worker, restoration can outlast AgentGateway's five-second request-parking budget. The gateway then cancels
ResumeActorand returns 504 before the test reaches its volume assertions. A two-minute client context does not extend that gateway budget. This affected main at 3230f9f and main at 0b91488d.Resume explicitly after suspend and revert through
ResumeActorAwaitCapacity, using the existing two-minute test context. Keep every image-volume, durable-directory, shared-mount, CSI reattachment, and revert-content assertion. The separate request-parking suite continues to cover traffic-triggered wakeup and budget exhaustion.Validation:
ResumeActor timed out after 5s; all 92 gVisor cases pass.8ae90df0.make verifyon the unmodified baseline and static verification after the change could not finish because the disk filled during compilation (ENOSPC); full verification completed in the Linux run above.The delay is confined to the personal-fork diagnostic workflow and is absent from this PR. The upstream PR workflow currently requires maintainer approval; the linked personal-fork runs use its same jobs to validate the PR head independently.