Repository navigation
e2e: run the identity suite with the others - #2227
Merged
Benjamin Elder (BenTheElder) merged 1 commit intoOct 6, 2026
Merged
Benjamin Elder (BenTheElder) merged 1 commit into
Benjamin Elder (BenTheElder) merged 1 commit into
Conversation
Lior Lieberman (LiorLieberman)
requested review from
Bowei Du (bowei) and
Tim Hockin (thockin)
October 6, 2026 00:40
Benjamin Elder (BenTheElder)
approved these changes
Oct 6, 2026
| // Only suites that ASSERT the projection ask for it. The bundle is derived | ||
| // from a single cluster-wide Secret, so a suite that merely needs a probe must | ||
| // not depend on it: it would then fail whenever the suite that owns the pool | ||
| // finishes and takes the bundle with it. For the same reason two suites that |
Collaborator
There was a problem hiding this comment.
nit: in CI the install now creates the pool, so this is stale?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2015 moved the identity suite into its own CI jobs. The test replaced the cluster-wide egress CA pool and caused actors stopped trusting the old CA right away, while gateways kept signing with the old ca until kubelet refreshed their Secret. This caused TLS TLS to fail for any suite running at the same time and therfore we splitted it.
The suite now adds a fresh CA that never signs and restores the pool when it ends. Bundles are compared as the same PEM blocks in any order, because atelet shuffles bundles with more than one certificate.
What the suite checks (exact file contents, live refresh, suspend/resume) is unchanged, and new unit tests check that the signing CA never changes.