Repository navigation
ateapi: describe no_capacity without "free worker" - #2137
Merged
Julian Gutierrez Oschmann (juli4n) merged 1 commit intoOct 6, 2026
Merged
Julian Gutierrez Oschmann (juli4n) merged 1 commit into
Julian Gutierrez Oschmann (juli4n) merged 1 commit into
Conversation
Jeff Luo (JeffLuoo)
requested review from
Benjamin Elder (BenTheElder) and
Julian Gutierrez Oschmann (juli4n)
October 2, 2026 19:24
| // ErrNoCapacity is returned by Schedule when no worker that meets the | ||
| // constraints has room. The cause can be full workers, or no worker that meets | ||
| // the constraints at all. | ||
| var ErrNoCapacity = errors.New("no worker that meets the constraints has room") |
Collaborator
There was a problem hiding this comment.
The word "room" sound a bit odd to me. Maybe "could not find worker that meets the actor requirements" or similar?
Collaborator
Author
There was a problem hiding this comment.
Thanks for looking. "Room" is the scheduler's own term
substrate/cmd/ateapi/internal/scheduling/scheduling.go
Lines 235 to 244 in c1ef2c3
I would like the message to match that, so that one condition has one name.
Collaborator
There was a problem hiding this comment.
Interesting. The code is evolving so far, sorry for the misleading comment!
Collaborator
There was a problem hiding this comment.
I'm not sure if this is the terminology we want either but we can bulk update it and I think this PR is strictly better than before
A worker can hold more than one actor, so "free worker" does not describe the capacity condition correctly. The scheduler returns ErrNoCapacity when no worker that meets the constraints has room. The cause can be full workers, or no worker that meets the constraints at all. The text of ErrNoCapacity, the comments on Schedule, and the ResourceExhausted message from AssignWorker now describe that condition. The new message is "no worker has room for the actor". The e2e checks that match the message, the tests, and the comments and docs that quote it use the new text. The CI failure analysis script matches both the old and the new message, so it still classifies older logs. A client that matches the old message text must change to the new text. The gRPC code does not change, so a client that checks ResourceExhausted is not affected.
Jeff Luo (JeffLuoo)
force-pushed
the
fix/issue-2128-free-worker-text
branch
from
October 5, 2026 15:46
b8640a7 to
c1ae86a
Compare
Jeff Luo (JeffLuoo)
requested a review
from Julian Gutierrez Oschmann (juli4n)
October 5, 2026 16:45
Krisztian F (krisztianfekete)
approved these changes
Oct 5, 2026
Julian Gutierrez Oschmann (juli4n)
approved these changes
Oct 5, 2026
Benjamin Elder (BenTheElder)
approved these changes
Oct 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A worker can hold more than one actor, so "free worker" does not describe the capacity condition correctly. The scheduler returns ErrNoCapacity when no worker that meets the constraints has room. The cause can be full workers, or no worker that meets the constraints at all.
Fixes #2128