Repository navigation
Make ate-apiserver report errors using apierror. - #2129
Merged
Luiz Oliveira (laoj2) merged 1 commit intoOct 5, 2026
Merged
Conversation
Luiz Oliveira (laoj2)
previously approved these changes
Oct 2, 2026
Julian Gutierrez Oschmann (juli4n)
marked this pull request as ready for review
October 2, 2026 16:32
Luiz Oliveira (laoj2)
enabled auto-merge
October 2, 2026 16:34
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 2, 2026
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
apierror-ateapi
branch
from
October 2, 2026 17:04
46d113d to
c7311ac
Compare
Luiz Oliveira (laoj2)
enabled auto-merge
October 2, 2026 17:35
Luiz Oliveira (laoj2)
previously approved these changes
Oct 2, 2026
This change is the counterpart of agent-substrate#2072, which changes the type used to report errors in atelet and ateom. The server interceptor will map grpc status from apierror packages, not from grpc status errors.
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
apierror-ateapi
branch
from
October 5, 2026 13:53
c7311ac to
97622f9
Compare
Luiz Oliveira (laoj2)
approved these changes
Oct 5, 2026
Merged
via the queue into
agent-substrate:main
with commit Oct 5, 2026
3dfddb1
16 of 19 checks passed
ILLUM1N0X
pushed a commit
to ILLUM1N0X/substrate
that referenced
this pull request
Oct 5, 2026
… to clients (agent-substrate#2196) Today the atenet depends on UNAVAILABLE to check if it should retry a ResumeActor call or not. We need a better contract for this (e.g. `RetryInfo` proto detail, see agent-substrate#1562). This is to keep the current behavior regressed by agent-substrate#2129
Lior Lieberman (LiorLieberman)
pushed a commit
to LiorLieberman/agent-substrate
that referenced
this pull request
Oct 6, 2026
I think this was a bad semantic merge between agent-substrate#2129 and the PR that introduced the new `AccessPolicy` sub-resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is the counterpart of #2072, which changes the type used to report errors in atelet and ateom.
The server interceptor will map grpc status from apierror packages, not from grpc status errors.