Repository navigation
atelet: try each matching image pull credential in turn - #2104
Merged
Zoe Zhao (zoez7) merged 2 commits intoOct 2, 2026
Merged
Zoe Zhao (zoez7) merged 2 commits into
Zoe Zhao (zoez7) merged 2 commits into
Conversation
Benjamin Elder (BenTheElder)
added
kind/bug
This was referenced Oct 2, 2026
Eitan Yarmush (EItanya)
left a comment
Eitan Yarmush (EItanya)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good overall, couple of comments from codex 🤖
Combine credentials from every provider matching an image and try them in order, like the kubelet: most specific auth key first, then config order. Skip failing providers instead of failing the pull.
Config and layer blobs are fetched after the manifest, so retry the full pull with the next credential, not just the manifest fetch. Skip a provider whose response has an unparseable auth key instead of failing.
Benjamin Elder (BenTheElder)
force-pushed
the
atelet-credential-provider-fallback
branch
from
October 2, 2026 16:51
c60e43b to
1ea6bc0
Compare
Eitan Yarmush (EItanya)
approved these changes
Oct 2, 2026
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combine credentials from every provider matching an image and try them in order, like the kubelet: most specific auth key first, then config order. Skip failing providers instead of failing the pull.
Follow up for #917 (review)