Repository navigation
Introduce a dedicated type for API errors. - #2072
Merged
Merged
Conversation
Before this PR, we were using grpc `status` errors to propagate the gRPC error a service need to return to client through the call stack. The main issue with this approach is that it can unintentionally propagate errors from upstream services. This change updates both atelet and ateom to use the new error type. A follow-up will update ate-apiserver, which is larger.
Luiz Oliveira (laoj2)
approved these changes
Oct 1, 2026
Luiz Oliveira (laoj2)
marked this pull request as ready for review
October 1, 2026 20:45
Luiz Oliveira (laoj2)
enabled auto-merge
October 1, 2026 20:45
Julian Gutierrez Oschmann (juli4n)
added a commit
to juli4n/substrate
that referenced
this pull request
Oct 2, 2026
This change is the counterpart of agent-substrate#2072, which changes the type used to report errors in atelet and ateom. The server interceptor will map grpc status from apierror packages, not from grpc status errors.
Julian Gutierrez Oschmann (juli4n)
added a commit
to juli4n/substrate
that referenced
this pull request
Oct 2, 2026
This change is the counterpart of agent-substrate#2072, which changes the type used to report errors in atelet and ateom. The server interceptor will map grpc status from apierror packages, not from grpc status errors.
Julian Gutierrez Oschmann (juli4n)
added a commit
to juli4n/substrate
that referenced
this pull request
Oct 2, 2026
This change is the counterpart of agent-substrate#2072, which changes the type used to report errors in atelet and ateom. The server interceptor will map grpc status from apierror packages, not from grpc status errors.
Julian Gutierrez Oschmann (juli4n)
added a commit
to juli4n/substrate
that referenced
this pull request
Oct 5, 2026
This change is the counterpart of agent-substrate#2072, which changes the type used to report errors in atelet and ateom. The server interceptor will map grpc status from apierror packages, not from grpc status errors.
Da Huang (git286)
pushed a commit
to git286/substrate
that referenced
this pull request
Oct 5, 2026
) This change is the counterpart of agent-substrate#2072, which changes the type used to report errors in atelet and ateom. The server interceptor will map grpc status from apierror packages, not from grpc status errors.
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, we were using grpc status errors to propagate the gRPC error a service need to return to client through the call stack.
The main issue with this approach is that it can unintentionally propagate errors from upstream services.
This change updates both atelet and ateom to use the new error type. A follow-up will update ate-apiserver, which is larger.