Repository navigation
atelet: take the DATA snapshot file set from ateom - #2028
Merged
Benjamin Elder (BenTheElder) merged 2 commits intoOct 1, 2026
Merged
Benjamin Elder (BenTheElder) merged 2 commits into
Benjamin Elder (BenTheElder) merged 2 commits into
Conversation
Haven Xia (HavenXia)
force-pushed
the
durable-data-files
branch
2 times, most recently
from
October 1, 2026 00:26
8b1cb54 to
7ab250a
Compare
To upload a FULL pause snapshot as a DATA snapshot, atelet picked thedurable-dir tar out of the file set by a name it shared with both ateoms. To decouple atelet and ateom further, ateom now reports the DATA subset in CheckpointWorkloadResponse and atelet reads from it, so narrowing a FULL capture ses that list instead of a file name.
Haven Xia (HavenXia)
force-pushed
the
durable-data-files
branch
from
October 1, 2026 22:42
7ab250a to
f6f5b04
Compare
| // its own set (gVisor's image files, cloud-hypervisor's snapshot set, ...). | ||
| repeated string snapshot_files = 1; | ||
|
|
||
| // data_snapshot_files is the subset of snapshot_files that restores the |
Collaborator
There was a problem hiding this comment.
should we just pass it as snapshot_files and we give a different list depending on the scope requested ..?
Collaborator
There was a problem hiding this comment.
Ok so ... if you take a local pause and then ask to snapshot we grab the files again. This feels kinda awkward but I don't have a better solution at the moment. Merge and iterate.
Benjamin Elder (BenTheElder)
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To upload a
FULLpause snapshot as aDATAsnapshot, atelet picks thedurable-dirtar out of the file set by a name it shared with both ateoms.To decouple atelet and ateom further, ateom now reports the
DATAsubset inCheckpointWorkloadResponseandatelet reads from the RPC response, so narrowing a
FULLdoesn't rely on the shared file namePart of #1846. It will eventually be replaced by the new logic in Actor lifecycle V2.