Repository navigation
workerservice: validate RequestActorSuspend requests - #2023
Merged
Julian Gutierrez Oschmann (juli4n) merged 1 commit intoOct 1, 2026
Merged
Julian Gutierrez Oschmann (juli4n) merged 1 commit into
Julian Gutierrez Oschmann (juli4n) merged 1 commit into
Conversation
Shrutiya Mohan (shrutiyam-glitch)
requested review from
Julian Gutierrez Oschmann (juli4n) and
Luiz Oliveira (laoj2)
September 30, 2026 21:31
Shrutiya Mohan (shrutiyam-glitch)
force-pushed
the
ateapi-dv-follow-up
branch
from
September 30, 2026 21:32
2f81e06 to
d1c0a77
Compare
Shrutiya Mohan (shrutiyam-glitch)
marked this pull request as ready for review
September 30, 2026 21:35
Maya Wang (mayawang)
added
kind/feature
| if req.GetActorUid() == "" { | ||
| return nil, status.Error(codes.InvalidArgument, "actor_uid is required") | ||
| if errs := apivalidation.ValidateRequestActorSuspendRequest(ctx, req); len(errs) > 0 { | ||
| return nil, status.Error(codes.InvalidArgument, errs.ToAggregate().Error()) |
Collaborator
There was a problem hiding this comment.
Use resources.ToGRPCStatusError.
Shrutiya Mohan (shrutiyam-glitch)
force-pushed
the
ateapi-dv-follow-up
branch
2 times, most recently
from
October 1, 2026 17:25
f364d67 to
06e7867
Compare
…laratively Wire apivalidation.ValidateRequestActorSuspendRequest and ValidateSetWorkerCapacityRequest into WorkerService, add +k8s:format=k8s-uuid to RequestActorSuspendRequest.actor_uid, and remove the hand-written checks and now-unused resources.ValidateGlobalObjectRef.
Shrutiya Mohan (shrutiyam-glitch)
force-pushed
the
ateapi-dv-follow-up
branch
from
October 1, 2026 17:35
06e7867 to
d5a377e
Compare
Shrutiya Mohan (shrutiyam-glitch)
requested a review
from Julian Gutierrez Oschmann (juli4n)
October 1, 2026 18:02
Julian Gutierrez Oschmann (juli4n)
enabled auto-merge
October 1, 2026 18:12
Julian Gutierrez Oschmann (juli4n)
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #2007
This switches the remaining two
WorkerServiceRPCs (RequestActorSuspendandSetWorkerCapacity) to declarative validation viacmd/ateapi/internal/apivalidation, completing declarative request validation acrossateapi.Removes the hand-written checks in
workerservice(validateActorRef,validateReportedCapacity) and the now-unusedresources.ValidateGlobalObjectRef.