Repository navigation
Reject repointing an actor that owns a snapshot to a different storage location - #2014
Merged
Zoe Zhao (zoez7) merged 1 commit intoOct 1, 2026
Merged
Conversation
Luiz Oliveira (laoj2)
force-pushed
the
repoint-storage-location
branch
from
September 30, 2026 19:30
babde60 to
7a93bd3
Compare
Maya Wang (mayawang)
added
kind/bug
Zoe Zhao (zoez7)
previously approved these changes
Sep 30, 2026
Comment on lines
+425
to
+428
| // Tag-owned snapshot | ||
| if !currentURI.OwnedBy(actorSnapshotOwner(actor)) { | ||
| return nil | ||
| } |
Collaborator
There was a problem hiding this comment.
I see so this will happen when I
- Create an actor from a Tag
- Do NOT resume it
- immdiately update the actor template.
Collaborator
Author
There was a problem hiding this comment.
just a correction: 2) should be: Do NOT SUSPEND it
The actor borrows the external snapshot of a tag (golden/source) until its first suspend.
Collaborator
|
needs rebase |
…different storage location This is needed because DeleteActor cleans up all snapshots under the actor's location. If we were to allow repointing an actor's snapshot location, we risked leaking historical snapshots upon actor deletion.
Luiz Oliveira (laoj2)
force-pushed
the
repoint-storage-location
branch
from
October 1, 2026 01:34
7a93bd3 to
aab2e11
Compare
Collaborator
Author
|
rebased |
Zoe Zhao (zoez7)
enabled auto-merge
October 1, 2026 03:30
Zoe Zhao (zoez7)
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed because DeleteActor cleans up all snapshots under the actor's location.
If we were to allow repointing an actor's snapshot location, we risked leaking historical snapshots upon actor deletion.