Repository navigation
ategcs: rename and move to pkg/ for reuse outside atelet - #2013
Merged
Merged
Conversation
Maya Wang (mayawang)
added
kind/cleanup
Michelle Au (msau42)
left a comment
Michelle Au (msau42)
left a comment
Collaborator
There was a problem hiding this comment.
After today's discussion, I think we actually want to move this to pkg/ so that it can be imported by plugin authors.
Eventually once we get the whole org/repo thing sorted out, I would actually want to move it to its own repo(s) as well.
Collaborator
ILLUM1N0X
force-pushed
the
pr1-ategcs
branch
from
September 30, 2026 23:57
4894fc2 to
60d8175
Compare
ILLUM1N0X
changed the title
The object storage client and its zstd, ranged and composed transfer helpers are needed by the snapshot plugin binary as well as atelet, and by snapshot plugins built outside this repository. Move the package from cmd/atelet/internal/ategcs to pkg/objectstorage so all of them can import it. No code changes besides the package name, import paths, the tracer name, and comments that named the old package. It stays separate from internal/objectstore, which only lists, copies and deletes objects for the control plane.
Michelle Au (msau42)
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1827
Moves
cmd/atelet/internal/ategcstopkg/objectstorageand renames the package toobjectstorage. No code changes besides the package name, its import path and uses, the tracer name, and comments that named the old package.Why: the Platform-Provided Snapshot API Proposal moves snapshot transfer out of atelet and ate-api-server into a snapshot plugin binary that runs as a sidecar. The reference plugin (GCS and S3) reuses this package's transfer code as is, and so can snapshot plugins built outside this repository, which is why it goes in
pkg/rather thaninternal/.Naming:
objectstorage, notobjectstore, becauseinternal/objectstorealready exists. That package only lists, copies and deletes objects for the control plane and is deliberately separate from this one (see its package comment, updated here). The snapshot plugin binary imports both.This PR stands alone and changes no behavior.
Reviewing:
git show -M --statshows 20 renames as{cmd/atelet/internal/ategcs => pkg/objectstorage}/.... Each changes only itspackageclause, except:objects.go: tracer nameategcs→objectstoragegcscompose_test.go,s3bench_test.go: thego test ./pkg/objectstoragepath in a comment;gcscompose_test.goalso renames its emulator test bucketThe other 4 files:
cmd/atelet/{main,main_test,sandbox_assets}.go: import path andategcs.→objectstorage., plus one comment inmain_test.gointernal/objectstore/objectstore.go: package comment now points atpkg/objectstorageTests pass (
make test,make verify)Appropriate changes to documentation are included in the PR (none needed)