Repository navigation
ate-setup: add the uniform configuration package - #2012
Merged
Haven Xia (HavenXia) merged 1 commit intoOct 5, 2026
Merged
Conversation
Steven Shriver (stshrive)
marked this pull request as ready for review
September 30, 2026 18:14
Anna Pendleton (annapendleton)
requested review from
Haven Xia (HavenXia) and
Anna Pendleton (annapendleton)
September 30, 2026 18:29
Member
|
below are other nits from agents |
Steven Shriver (stshrive)
force-pushed
the
dev/uniform-config-file
branch
from
October 1, 2026 16:21
5b251ce to
47eaf72
Compare
Collaborator
Author
|
Agent review comments were resolved in latest changes. |
Steven Shriver (stshrive)
force-pushed
the
dev/uniform-config-file
branch
from
October 1, 2026 19:15
47eaf72 to
4fd96a1
Compare
Settings reach the installer through a few existing channels 1. Flags 2. Environment variables This changes adds the mechanics of a third: _A file-based configuration_. Specifically it adds: 1. A single declaration per setting with precedence resolution that retains the origin that set it. 2. A document format that rejects unknown keys rather than falling back to a default in silence 3. Errors that name the channel a bad value came from 4. A reporting mechanism of what a run resolved 5. Reading and writing a record of a run's settings. **Next Steps**: Wire the new config system into install path. Nothing calls any of this. The existing parsing path is untouched, so the same flags, variables and messages come out as before. This change leaves the `Registry` empty. The settings themselves are wiring changes with each one entry replacing a declaration from somewhere else. Moving them belongs with the following change. Tests that need settings register their own fixtures. Tests that can only be written against a filled registry carry a TODO.
Steven Shriver (stshrive)
force-pushed
the
dev/uniform-config-file
branch
from
October 1, 2026 20:25
4fd96a1 to
d949a57
Compare
Steven Shriver (stshrive)
requested a review
from Lior Lieberman (LiorLieberman)
October 1, 2026 21:39
Haven Xia (HavenXia)
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings reach the installer through a few existing channels
This changes adds the mechanics of a third: A file-based configuration. Specifically it adds:
Nothing calls any of this. The existing parsing path is untouched, so the same flags, variables and messages come out as before.
Next Steps: Wire the new config system into install path.
Notes about this change:
This change leaves the
Registryempty. The settings themselves are wiring changes with each one entry replacing a declaration from somewhere else. Moving them belongs with the following change.Tests that need settings register their own fixtures. Tests that can only be written against a filled registry carry a TODO.
This work is for #1887