Repository navigation
Move DV validators under apivalidations. - #2007
Merged
Luiz Oliveira (laoj2) merged 1 commit intoSep 30, 2026
Merged
Conversation
Both `Control` and `WorkerService` APIs need to access them so moving it under a shared internal package. This also aligns ate-apiserver with how atelet uses DV as serves as a prefactor for upcoming changes to the `ServiceImpl` type.
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
apivalidations
branch
from
September 30, 2026 17:08
3a7fbf1 to
d39fefd
Compare
Julian Gutierrez Oschmann (juli4n)
requested a review
from Luiz Oliveira (laoj2)
September 30, 2026 17:25
Julian Gutierrez Oschmann (juli4n)
marked this pull request as ready for review
September 30, 2026 17:25
Bowei Du (bowei)
added
area/api
Luiz Oliveira (laoj2)
approved these changes
Sep 30, 2026
Luiz Oliveira (laoj2)
enabled auto-merge
September 30, 2026 17:40
Haven Xia (HavenXia)
approved these changes
Sep 30, 2026
2 tasks done
Scott Funkenhauser (sfunkenhauser)
pushed a commit
to sfunkenhauser/substrate
that referenced
this pull request
Oct 1, 2026
…#2023) Follow up on agent-substrate#2007 This switches the remaining two `WorkerService` RPCs (`RequestActorSuspend` and `SetWorkerCapacity`) to declarative validation via `cmd/ateapi/internal/apivalidation`, completing declarative request validation across `ateapi`. Removes the hand-written checks in `workerservice` (`validateActorRef`, `validateReportedCapacity`) and the now-unused `resources.ValidateGlobalObjectRef`. - [x] Tests pass - [x] Appropriate changes to documentation are included in the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
ControlandWorkerServiceAPIs need to access them so moving it under a shared internal package.This also aligns ate-apiserver with how atelet uses DV as serves as a prefactor for upcoming changes to the
ServiceImpltype.Fixes #1823