Repository navigation
ateapi: release a suspend's replaced snapshot after committing SUSPENDED - #2006
Merged
Luiz Oliveira (laoj2) merged 1 commit intoSep 30, 2026
Merged
Luiz Oliveira (laoj2) merged 1 commit into
Luiz Oliveira (laoj2) merged 1 commit into
Conversation
haiyanmeng
requested review from
Julian Gutierrez Oschmann (juli4n) and
Zoe Zhao (zoez7)
September 30, 2026 14:20
Julian Gutierrez Oschmann (juli4n)
requested a review
from Luiz Oliveira (laoj2)
September 30, 2026 14:37
Luiz Oliveira (laoj2)
previously approved these changes
Sep 30, 2026
FinalizeSuspended deleted the external snapshot a suspend replaced before committing SUSPENDED. By then the new checkpoint is uploaded and the worker's assignment row is released, so a transient object-store error (429/503) on that delete aborted the workflow with the actor stuck in SUSPENDING: ResumeActor rejects that state with FailedPrecondition, and a retried suspend re-sends Checkpoint to the already-released worker, which most likely crashes the actor despite a good snapshot in storage. Commit SUSPENDED first, then release the replaced snapshot best-effort, logging a failure instead of returning it. A failed release now leaves the old snapshot's objects in storage until the actor is deleted, which removes its whole prefix, rather than stranding the actor. A commit lost to a concurrent update releases nothing, since the record still names the old snapshot.
haiyanmeng
force-pushed
the
actor-stuck-in-pending
branch
from
September 30, 2026 15:48
7b88317 to
935790d
Compare
Luiz Oliveira (laoj2)
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FinalizeSuspended deleted the external snapshot a suspend replaced before committing SUSPENDED. By then the new checkpoint is uploaded and the worker's assignment row is released, so a transient object-store error (429/503) on that delete aborted the workflow with the actor stuck in SUSPENDING: ResumeActor rejects that state with FailedPrecondition, and a retried suspend re-sends Checkpoint to the already-released worker, which most likely crashes the actor despite a good snapshot in storage.
Commit SUSPENDED first, then release the replaced snapshot best-effort, logging a failure instead of returning it. A failed release now leaves the old snapshot's objects in storage until the actor is deleted, which removes its whole prefix, rather than stranding the actor. A commit lost to a concurrent update releases nothing, since the record still names the old snapshot.