Repository navigation
envoy dyn module followup - #1995
Merged
Bowei Du (bowei) merged 2 commits intoSep 30, 2026
Merged
Conversation
Lior Lieberman (LiorLieberman)
added
the
DO NOT MERGE
Lior Lieberman (LiorLieberman)
changed the title
yanavlasov
approved these changes
Sep 30, 2026
Lior Lieberman (LiorLieberman)
changed the title
Lior Lieberman (LiorLieberman)
removed
the
DO NOT MERGE
Lior Lieberman (LiorLieberman)
force-pushed
the
egress-plumbing-fixes
branch
from
September 30, 2026 15:45
b94cc8a to
15aff01
Compare
Bowei Du (bowei)
approved these changes
Sep 30, 2026
Bowei Du (bowei)
left a comment
Bowei Du (bowei)
left a comment
Collaborator
There was a problem hiding this comment.
looks good, some follow-ups after this PR:
- Split the policy eval into it's own file (module) the rust plugin and exhaustively define and test its behavior
- Anywhere we have malformed config input, we should error log in Envoy at least once.
| } | ||
| return &structpb.Struct{Fields: fields} | ||
| // connectMetadata encodes the SNI rules for EgressPolicyMetadataNamespace. | ||
| // An empty list denies all TLS. |
Collaborator
There was a problem hiding this comment.
Remove this comment. (this is a struct not a list)
Collaborator
Author
There was a problem hiding this comment.
this talks on the SNI rules list.
Bowei Du (bowei)
added
area/network
kind/feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements:
tls_passhtrough is a followup.