Skip to content

Clean up vestigial metadata setting in atepg - #1992

Merged
Luiz Oliveira (laoj2) merged 1 commit into
agent-substrate:mainfrom
thockin:atepg_metadata_set
Sep 30, 2026
Merged

Luiz Oliveira (laoj2) merged 1 commit into
agent-substrate:mainfrom
thockin:atepg_metadata_set

Conversation

@thockin

Copy link
Copy Markdown
Collaborator

This was mostly changed when DV was introduced, but this slipped past.

Comment thread cmd/ateapi/internal/store/atepg/tag.go Outdated
if err := mutate(dbTag); err != nil {
return nil, err
}
// TODO: this should be don through DV and removed from here

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "done"?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@EItanya
Eitan Yarmush (EItanya) added this pull request to the merge queue Sep 30, 2026
@EItanya
Eitan Yarmush (EItanya) removed this pull request from the merge queue due to a manual request Sep 30, 2026
@EItanya

Copy link
Copy Markdown
Collaborator

Added to the merge queue, but then saw the pending typo so holding off

This was mostly changed when DV was introduced, but this slipped past.
@thockin

Copy link
Copy Markdown
Collaborator Author

re-pushed

@bowei Bowei Du (bowei) added area/api-machinery kind/cleanup Small fixes that are not bugs, for example a typo in a code comment labels Sep 30, 2026
@laoj2
Luiz Oliveira (laoj2) added this pull request to the merge queue Sep 30, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Sep 30, 2026
@laoj2
Luiz Oliveira (laoj2) added this pull request to the merge queue Sep 30, 2026
Merged via the queue into agent-substrate:main with commit ce05e5d Sep 30, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api-machinery kind/cleanup Small fixes that are not bugs, for example a typo in a code comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants