Repository navigation
Pin envoy-dataplane from the release on a pre-built install - #1964
Merged
Lior Lieberman (LiorLieberman) merged 2 commits intoSep 29, 2026
Merged
Lior Lieberman (LiorLieberman) merged 2 commits into
Lior Lieberman (LiorLieberman) merged 2 commits into
Conversation
envoy-dataplane is built from a Dockerfile, not with ko. ate-setup always built it with docker buildx, even for `deploy --image-repo --image-tag`, which has no registry to push to, so a pre-built install failed on the default envoy router after applying the control plane. A pre-built install now pins REPO/envoy-dataplane:TAG like the ko images. To publish it, `make build-envoy-dataplane` builds the image, and `make build-release-images` builds every image a pre-built install needs (ko images, demos, envoy-dataplane), all tagged $(VERSION). The ko tag goes in a new KO_TAGS variable so a KO_FLAGS override doesn't drop it.
Anna Pendleton (annapendleton)
force-pushed
the
envoy-prebuilt
branch
from
September 28, 2026 23:09
db0f107 to
9ac64c7
Compare
Anna Pendleton (annapendleton)
requested a review
from Lior Lieberman (LiorLieberman)
September 29, 2026 18:52
Collaborator
|
Taking a look in an hour or so. We just "broke" it recently |
Lior Lieberman (LiorLieberman)
approved these changes
Sep 29, 2026
Collaborator
There was a problem hiding this comment.
Ok, looks good to me, but note that we will have today or tomorrow a version that is different and implements the spec fully. yanavlasov is working on it.
Do you prefer merging this now or wait until we get that other changes in?
Collaborator
|
LGTM |
Steven Shriver (stshrive)
approved these changes
Sep 29, 2026
Collaborator
Author
|
Lior Lieberman (@LiorLieberman) I prefer merging this now as it's blocking our ability to do an official GKE release of v0.2 branch. We need to cherrypick this into the release-0.2 branch after this is merged. |
3 tasks done
Bowei Du (bowei)
added
area/dev-infra
area/network
kind/bug
Lior Lieberman (LiorLieberman)
pushed a commit
that referenced
this pull request
Sep 30, 2026
…1990) Cherry-picking #1964 Without it, a pre-built install of v0.2.x (`ate-setup deploy --image-repo --image-tag`) fails on the default envoy router: ate-setup builds envoy-dataplane with docker buildx and has no registry to push to. This brings the fix to release-0.2, along with `make build-envoy-dataplane` and `make build-release-images`, so a 0.2 release can publish the full image set. Only #1964's changes are included: the same 9 files and an identical diff, nothing else from main. Related: #1962 - [x] #1964 merged into main - [x] Tests pass - [x] Appropriate changes to documentation are included in the PR Co-authored-by: Anna Pendleton <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ate-setup deploy --image-repo REPO --image-tag TAG) now pinsREPO/envoy-dataplane:TAGlike the ko images, instead of building it with docker buildx.make build-envoy-dataplanepublishes that image.make build-release-imagespublishes every image a pre-built install needs (ko images, demos, envoy-dataplane), all tagged$(VERSION).Why
envoy-dataplane (#1535) is built from a Dockerfile, and ate-setup built it even for pre-built installs. Those installs have no registry to push to, so they failed on the default envoy router after the control plane was applied. It also couldn't join
ALL_IMAGES, which only lists ko builds, so nothing published it for a release.Testing
mainwith the production error (invalid tag "/envoy-dataplane:build-…").make build-release-imagespushed all 13 images under one tag, andimages.Prebuiltpinned every one against the real registry.release-0.2.Fixes #1962