Repository navigation
oidcdiscovery: build the OpenID discovery document - #1963
Merged
Taahir Ahmed (ahmedtd) merged 1 commit intoOct 3, 2026
Merged
Taahir Ahmed (ahmedtd) merged 1 commit into
Taahir Ahmed (ahmedtd) merged 1 commit into
Conversation
Max Thompson (thompsonmax)
marked this pull request as ready for review
September 29, 2026 16:40
Max Thompson (thompsonmax)
requested review from
Shruti Nair (SHRUTI6991) and
Taahir Ahmed (ahmedtd)
September 29, 2026 16:40
Maya Wang (mayawang)
added
area/identity
kind/feature
2 tasks
Eitan Yarmush (EItanya)
left a comment
Eitan Yarmush (EItanya)
left a comment
Collaborator
There was a problem hiding this comment.
These changes LGTM, but would like Taahir Ahmed (@ahmedtd) to weigh in as well
Add DiscoveryDocument, which returns the JSON a relying party fetches from <issuer>/.well-known/openid-configuration to find the actor JWT signing keys. It copies the issuer verbatim and derives jwks_uri by trimming one trailing slash and appending /openid/v1/jwks, the path the Kubernetes service account issuer uses. id_token_signing_alg_values_supported lists each distinct algorithm the caller passes, sorted. There is no authorization_endpoint, since the issuer has no login flow.
Max Thompson (thompsonmax)
force-pushed
the
oidc-discovery-document
branch
from
October 2, 2026 16:41
8c6984f to
39fea82
Compare
Taahir Ahmed (ahmedtd)
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1756.
oidcdiscovery.DiscoveryDocument, which builds the JSON a relying party fetches from<issuer>/.well-known/openid-configurationto find the actor JWT signing keys.jwks_uritrims one trailing slash and appends/openid/v1/jwks, the same path as the Kubernetes service account issuer.id_token_signing_alg_values_supportedlists each distinct algorithm passed in, sorted. There is noauthorization_endpoint, since the issuer has no login flow.Nothing calls this yet. A follow-up PR adding ate-idp-server will.
Testing: unit tests, including an exact comparison of the JSON. Nothing exercises it end to end yet.