Repository navigation
Snapshot path validation - #1950
Merged
Haven Xia (HavenXia) merged 4 commits intoSep 28, 2026
Merged
Haven Xia (HavenXia) merged 4 commits into
Haven Xia (HavenXia) merged 4 commits into
Conversation
moveLocalCheckpoint hardcoded the checkpoint-state and local-checkpoint directory names; derive them from ateletpath instead. Also Lstat the checkpoint file so a symlink is rejected rather than moved, and let copyRootFile take a single root now that its only caller passes one.
filepath.IsLocal still let through nested paths, ".", and aliases like "./checkpoint.img" that resolve to the same file as another entry, which a DATA_ON_GOLDEN restore would then write concurrently. It also accepted manifest.json, which atelet overwrites with its own record. Reject all of these.
Haven Xia (HavenXia)
enabled auto-merge
September 28, 2026 20:13
Merged
via the queue into
agent-substrate:main
with commit Sep 28, 2026
5b7417e
10 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1426
Rebases that PR and adjusts to changes in main since. #1426 (comment)
Addresses outstanding review comments in additional commits.
I want to get this in M3.