Skip to content

Snapshot path validation - #1950

Merged
Haven Xia (HavenXia) merged 4 commits into
agent-substrate:mainfrom
BenTheElder:snapshot-path-validation
Sep 28, 2026
Merged

Haven Xia (HavenXia) merged 4 commits into
agent-substrate:mainfrom
BenTheElder:snapshot-path-validation

Conversation

@BenTheElder

@BenTheElder Benjamin Elder (BenTheElder) commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #1426

Rebases that PR and adjusts to changes in main since. #1426 (comment)

Addresses outstanding review comments in additional commits.

I want to get this in M3.

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

Du Bin (dubin555) and others added 4 commits September 28, 2026 12:04
moveLocalCheckpoint hardcoded the checkpoint-state and local-checkpoint
directory names; derive them from ateletpath instead. Also Lstat the
checkpoint file so a symlink is rejected rather than moved, and let
copyRootFile take a single root now that its only caller passes one.
filepath.IsLocal still let through nested paths, ".", and aliases like
"./checkpoint.img" that resolve to the same file as another entry, which
a DATA_ON_GOLDEN restore would then write concurrently. It also accepted
manifest.json, which atelet overwrites with its own record. Reject all of
these.

@HavenXia Haven Xia (HavenXia) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HavenXia
Haven Xia (HavenXia) added this pull request to the merge queue Sep 28, 2026
Merged via the queue into agent-substrate:main with commit 5b7417e Sep 28, 2026
10 of 11 checks passed
@bowei Bowei Du (bowei) added area/security Security related issue/pr area/storage kind/bug Something isn't working / bugfixes labels Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/node area/security Security related issue/pr area/storage kind/bug Something isn't working / bugfixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants