Repository navigation
Select kvm-clock for amd64 micro-VM guests - #1945
Benjamin Elder (BenTheElder) merged 1 commit into
Conversation
|
The description of #1634 is huge (please prefer concise human communication for communication and use LLMs to assist with writing code/debuggin), can you please add a short description of why we want this change? Nothing in the PR body explains why we'd want this change itself, nor does it point at an open issue describing this. |
Sorry, my bad. Let me update. The PR's been open for 2 weeks and through rebases/fixes and scope changes - I got a little lazy with the PR description updates last couple of days. Thanks for calling it out. |
|
Updated the PR descriptions, PTAL! |
e63120e to
a0c08aa
Compare
Eitan Yarmush (EItanya)
left a comment
Eitan Yarmush (EItanya)
left a comment
There was a problem hiding this comment.
Benjamin Elder (@BenTheElder) I verified this fix on my end so i'll give it the LGTM, but will leave final merge to you
|
Thanks for the review! Eitan Yarmush (@EItanya) |
Benjamin Elder (BenTheElder)
left a comment
Benjamin Elder (BenTheElder)
left a comment
There was a problem hiding this comment.
Thanks!
I must've only tested on arm64 ...
Unrelated, but do we think we should be doing multi-arch e2e testing in CI? This is quite the potential regression, and I'm wondering if elsewhere there be dragons |
…rate#1634) Addresses agent-substrate#1017 by adding E2E tests for HTTPS and WebSocket egress. Added scope after the egress policy was finalized: [review comment](agent-substrate#1634 (comment)). Updates the gateways to reject HTTP/1.1 WebSocket upgrades with 403. PRs merge order/stack: agent-substrate#1945 agent-substrate#1944 and then this PR
sets
clocksource=kvm-clock; fixes from CI failures on #1634