Repository navigation
nodepath: move the node state root to /var/lib/ate - #1926
Merged
Benjamin Elder (BenTheElder) merged 1 commit intoSep 28, 2026
Merged
Conversation
Collaborator
Author
|
Do we want to do this? Tim Hockin (@thockin) Benjamin Elder (@BenTheElder) |
Collaborator
|
I am AFK most of today, but we don't have to be so careful with compat (yet). |
/var/lib/ateom-gvisor predates the micro-VM class; worker pods of both classes mount it. Every component, manifest, script and doc moves to the new name. No compatibility path: a rolling upgrade rolls the pools once at the controller step, and a worker on a node whose atelet still uses the old path reaches it only once that node moves.
Davanum Srinivas (dims)
force-pushed
the
pr/node-state-root
branch
from
September 27, 2026 17:00
195de52 to
f77359e
Compare
Collaborator
Author
thanks Tim Hockin (@thockin) reworked it |
Davanum Srinivas (dims)
marked this pull request as ready for review
September 27, 2026 18:26
Benjamin Elder (BenTheElder)
approved these changes
Sep 28, 2026
Benjamin Elder (BenTheElder)
left a comment
Benjamin Elder (BenTheElder)
left a comment
Collaborator
There was a problem hiding this comment.
We might put something in the docs about how to bulk cleanup existing installs but generally I agree we don't need backcompat at this point.
Bowei Du (bowei)
added
area/dev-infra
area/node
kind/cleanup
kubernetes-prow Bot
pushed a commit
to kubernetes-sigs/gcp-filestore-csi-driver
that referenced
this pull request
Oct 29, 2026
Agent Substrate moved its node state root from /var/lib/ateom-gvisor to /var/lib/ate (agent-substrate/substrate#1926) and now asks the CSI node plugin to mount actor volumes at /var/lib/ate/actors/<uid>/volumes/<name>. The overlay only propagated /var/lib/ateom-gvisor, so on current Substrate the NFS mount stayed inside the node plugin container and the actor saw an empty directory. Keep /var/lib/ateom-gvisor for Substrate release-0.1 and add /var/lib/ate with the same bidirectional propagation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1911
/var/lib/ateom-gvisorwas named when gVisor was the only sandbox class; worker pods of both classes mount it. This renamesnodepath.BasePathto/var/lib/ateeverywhere it is spelled out: atelet's manifest, the kind CSI scripts,ate-setup's CSI step, and the docs. The controller's worker pod mounts follow the constant.No compatibility path, per the comment above. A rolling upgrade rolls the pools once at the controller step, and a worker that lands on a node whose atelet still uses the old path reaches it only once that node moves;
docs/upgrade.mdsays so. The old directory can be deleted afterwards.