Repository navigation
feat(ateapi): send resolved sandbox assets during restore - #1866
Merged
Zoe Zhao (zoez7) merged 7 commits intoSep 25, 2026
Merged
Conversation
Restores get their sandbox binaries and pause image from the snapshot manifest, which is stored with the snapshot data. Add a field so the control plane can send them instead, as it already does for Run.
Resolve the ActorTemplate's SandboxConfig once in ensureAteletRestored and set it on the local and external RestoreRequest, not only on the cold-boot RunRequest. A missing SandboxConfig now stops a restore before it reaches atelet.
Shrutiya Mohan (shrutiyam-glitch)
changed the title
Shrutiya Mohan (shrutiyam-glitch)
marked this pull request as ready for review
September 24, 2026 21:18
Shrutiya Mohan (shrutiyam-glitch)
force-pushed
the
issue-1835
branch
from
September 25, 2026 15:38
c64f344 to
ab1dea0
Compare
Zoe Zhao (zoez7)
approved these changes
Sep 25, 2026
Zoe Zhao (zoez7)
enabled auto-merge
September 25, 2026 15:40
2 tasks done
Bowei Du (bowei)
added
area/api-machinery
area/node
area/security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1835
ateletchose the sandbox binaries and pause image for a restore from the snapshot'smanifest.jsonrather than from the control plane. This PR makes ateapi send them on every restore, the way it already does for Run.Changes
sandbox_assetstoatelet.RestoreRequest.ensureAteletRestoredresolves the ActorTemplate's SandboxConfig once and sends it on the local restore, the external restore and Run. A missing SandboxConfig now fails before any atelet call.sandbox_assetsis required on Restore. Restore selects the binaries and pause image withrecordFromRequest, the same path Run uses. The manifest still supplies the snapshot files, sandbox class and metrics labels.Note - The field is required, so after atelet is upgraded, resumes on that node fail until ate-api-server is upgraded too.
Testing
ateapi: every Run and Restore sends the resolved assets; a missing SandboxConfig fails on both restore paths.
atelet:
TestRecordFromRequest, a validation case for a missing field, andTestRestoreUsesRequestSandboxAssets(checkpoint with pause image v1, restore with v2, and the actor runs with v2).Tests pass
Appropriate changes to documentation are included in the PR