Repository navigation
ateapi: rename --egress-gateway-address to --default-egress-gateway-address - #1858
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
167616c to
9478513
Compare
Bowei Du (bowei)
added
kind/cleanup
|
The PR no longer changes it to experimental, description should be udpated |
Lior Lieberman (LiorLieberman)
changed the title
…ed-egress-gateway-address (agent-substrate#1591) Prefix the cluster-wide egress PEP address flag with 'experimental-to-be-removed-' to indicate it is a temporary cluster-level knob that will be removed once per-actor egress gateway configuration is supported (agent-substrate#1591). Keep --egress-gateway-address as a deprecated alias for backward compatibility.
66fbd4f to
6c9a584
Compare
|
Agreed that it is good to break things Pre-GA |
I would generally agree, and I initially did leave the previous flag and gave a warning but decided to delete it. We have an opportunity to break things now, which we wont have later. The less residuals we can stay with the better IMO. I know it comes with some inconvenience for downstream projects but its very limited now. GA is coming pretty fast :-) |
Prefix the cluster-wide egress PEP address flag with
default-'experimental-to-be-removed-' to indicate it is a temporary cluster-level knob that will be removedonce per-actor or per-atespace egress gateway configuration is supported (#1591).~I kept --egress-gateway-address as a deprecated alias for backward compatibility but I really dont think we should. ~
I removed it, we dont need backward comp residuals pre GA
EDIT: I chatted with tim and taahir a the feedback was that its not really experimental and can not really be removed. This flag would have to be set for every GA user, and its not a nice experimental add on. We dont have time to get into per-actor or per-atespace API discussions pre-GA therfore we gotta have to live with it and discourage later if we have a better story for that.
Related #1591
/cc Bowei Du (@bowei) Eitan Yarmush (@EItanya)