Repository navigation
ate-setup: wait for ate-system namespace termination during teardown/… - #1851
Merged
Max Smythe (maxsmythe) merged 1 commit intoSep 24, 2026
Conversation
…deploy When orchestrator runs consecutive benchmark tests, DeleteAteSystem previously returned immediately after initiating deletion of the ate-system namespace without waiting for termination to complete. Because draining atelet DaemonSets and postgres takes ~60s, the subsequent test's EnsureAteSystemNamespace often timed out waiting for the Terminating namespace to become Active. Wait for namespace/ate-system deletion in DeleteAteSystem and EnsureAteSystemNamespace (as well as hack/install-ate.sh) so consecutive benchmark deployments do not race with namespace termination.
Chenyi Wang (chw120)
force-pushed
the
fix-ate-system-namespace-termination
branch
from
September 24, 2026 08:24
b1d1df6 to
d404d67
Compare
Chenyi Wang (chw120)
deleted the
fix-ate-system-namespace-termination
branch
September 24, 2026 17:39
Bowei Du (bowei)
added
area/dev-infra
kind/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
orchestrator.pyruns consecutive benchmark tests in Prow,teardown_substrate()runshack/install-ate.sh --delete-ate-system(DeleteAteSystem), which previously returned immediately after issuing asynchronous deletion on theate-systemnamespace without waiting for termination to complete.Because draining
ateletDaemonSets across 15 nodes andpostgrestakes ~60–65 seconds:deploy_substrate()(EnsureAteSystemNamespace) ~1 second later whilenamespace/ate-systemis stillTerminating.ApplyPath("ate-system-namespace.yaml")merely updates the terminating namespace object, and once the old namespace finishes deleting and transitions toNotFound,WaitNamespaceActivenever re-applies the manifest and times out after 60s (waiting for namespace ate-system to become Active: context deadline exceeded).*_pauseM1 benchmarks) failed duringdeploy_substrate()in ~90% of Prow runs before Locust could start.Fix
DeleteAteSystem(cmd/ate-setup/internal/steps/delete.go): Wait fornamespace/<ns>deletion (WaitDeleted) to complete before returning from teardown.EnsureAteSystemNamespace(cmd/ate-setup/internal/steps/env.go): If the target namespace already exists inTerminatingphase when deploy starts, wait for it to finish deleting before applyingate-system-namespace.yaml/EnsureNamespace.