Skip to content

Add DV for GoldenSnapshotStatus and unbounded strings - #1831

Merged
Scott Funkenhauser (sfunkenhauser) merged 3 commits into
agent-substrate:mainfrom
laoj2:missing-dv
Sep 24, 2026
Merged

Add DV for GoldenSnapshotStatus and unbounded strings#1831
Scott Funkenhauser (sfunkenhauser) merged 3 commits into
agent-substrate:mainfrom
laoj2:missing-dv

Conversation

@laoj2

@laoj2 Luiz Oliveira (laoj2) commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Fixes #1168

  • Add DV for GoldenSnapshotStatus and truncate its error_message to fit
  • Require ExternalSnapshot.actor_template_uid to be a UUID
  • Bound ExternalVolumeTemplate.capacity to 32 characters

Merged via the queue into agent-substrate:main with commit 34f3003 Sep 24, 2026
11 checks passed
@bowei Bowei Du (bowei) added area/api User-facing API changes area/api-machinery kind/cleanup Small fixes that are not bugs, for example a typo in a code comment labels Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfunkenhauser Scott Funkenhauser (sfunkenhauser) sfunkenhauser approved these changes
@juli4n Julian Gutierrez Oschmann (juli4n) Awaiting requested review from juli4n
@thockin Tim Hockin (thockin) Awaiting requested review from thockin
+1 more reviewer
@shrutiyam-glitch Shrutiya Mohan (shrutiyam-glitch) shrutiyam-glitch approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/api User-facing API changes area/api-machinery kind/cleanup Small fixes that are not bugs, for example a typo in a code comment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adopt Declarative Validation (DV) for resource operations

4 participants

@laoj2 @sfunkenhauser @shrutiyam-glitch @bowei