Repository navigation
Add DeletePreconditions to all Delete<Resource> methods - #1807
Merged
Luiz Oliveira (laoj2) merged 1 commit intoSep 23, 2026
Merged
Conversation
Julian Gutierrez Oschmann (juli4n)
requested a review
from Luiz Oliveira (laoj2)
September 22, 2026 21:27
Julian Gutierrez Oschmann (juli4n)
marked this pull request as ready for review
September 22, 2026 21:29
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
delete_preconditions
branch
3 times, most recently
from
September 23, 2026 13:41
a81075b to
b719332
Compare
Luiz Oliveira (laoj2)
previously approved these changes
Sep 23, 2026
| } | ||
| } | ||
|
|
||
| // foreignUID matches no stored object, for guards that must miss. |
Collaborator
There was a problem hiding this comment.
nit: can we move this to workflow_tag_test.go? It's only used there
Collaborator
Author
There was a problem hiding this comment.
Done.
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
delete_preconditions
branch
from
September 23, 2026 14:28
b719332 to
0708bd0
Compare
Luiz Oliveira (laoj2)
previously approved these changes
Sep 23, 2026
2 tasks done
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
delete_preconditions
branch
2 times, most recently
from
September 23, 2026 17:37
2ef60b3 to
4755644
Compare
Luiz Oliveira (laoj2)
enabled auto-merge
September 23, 2026 17:49
Luiz Oliveira (laoj2)
previously approved these changes
Sep 23, 2026
Allow clients to do optimistic locking on deletes, as well as prevent unintended deletes on name reuse.
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
delete_preconditions
branch
from
September 23, 2026 18:28
4755644 to
2bd1b37
Compare
Luiz Oliveira (laoj2)
approved these changes
Sep 23, 2026
14 of 17 tasks
Bowei Du (bowei)
added
area/api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow clients to do optimistic locking on deletes, as well as prevent unintended deletes on name reuse.
#866