Skip to content

doc: egress credential injection with sample k8s secret credential pr… - #1805

Merged
Bowei Du (bowei) merged 2 commits into
agent-substrate:mainfrom
yufan-su:doc-cred-injection
Sep 28, 2026
Merged

doc: egress credential injection with sample k8s secret credential pr…#1805
Bowei Du (bowei) merged 2 commits into
agent-substrate:mainfrom
yufan-su:doc-cred-injection

Conversation

@yufan-su

@yufan-su Yufan Su (yufan-su) commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

add docs on egress credential injection and example k8s secret credential provider.

  • Appropriate changes to documentation are included in the PR

@yufan-su Yufan Su (yufan-su) added the kind/docs Improvements or additions to documentation label Sep 22, 2026
bowei
Bowei Du (bowei) reviewed Sep 25, 2026
View reviewed changes

@bowei Bowei Du (bowei) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment I have is that it's not clear who the intended audience is for the doc, as it seems to be targeted towards internal developers vs end users vs provider implementors. I think we should do a sweep closer to GA and split these off. At least group the sections in the doc so people don't get overwhelmed with details.

Comment thread docs/egress-credential-injection.md Resolved
Comment thread docs/egress-credential-injection.md Resolved
@yufan-su
Yufan Su (yufan-su) force-pushed the doc-cred-injection branch 3 times, most recently from 0736a82 to f27e7d1 Compare September 28, 2026 20:08
@yufan-su

Yufan Su (yufan-su) commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator Author

One comment I have is that it's not clear who the intended audience is for the doc, as it seems to be targeted towards internal developers vs end users vs provider implementors. I think we should do a sweep closer to GA and split these off. At least group the sections in the doc so people don't get overwhelmed with details.

updated doc, to first have high level concepts and examples for general readers. And implementation details for cluster admin and custom credential provider developers

@thompsonmax Max Thompson (thompsonmax) mentioned this pull request Sep 28, 2026
Merged
2 tasks done
@bowei
Bowei Du (bowei) added this pull request to the merge queue Sep 28, 2026
Merged via the queue into agent-substrate:main with commit dd57a11 Sep 28, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bowei Bowei Du (bowei) bowei approved these changes
@LiorLieberman Lior Lieberman (LiorLieberman) Awaiting requested review from LiorLieberman

Assignees

No one assigned

Labels

kind/docs Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yufan-su @bowei