Repository navigation
Add DV for TagStatus + drop unused TagStatus.source_actor_uid field - #1772
Merged
Julian Gutierrez Oschmann (juli4n) merged 3 commits intoSep 23, 2026
Merged
Conversation
Luiz Oliveira (laoj2)
requested review from
Julian Gutierrez Oschmann (juli4n) and
Shrutiya Mohan (shrutiyam-glitch)
September 21, 2026 14:51
Julian Gutierrez Oschmann (juli4n)
previously approved these changes
Sep 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Sep 21, 2026
Luiz Oliveira (laoj2)
force-pushed
the
tag-cleanups
branch
from
September 21, 2026 22:12
369557e to
8e203db
Compare
Luiz Oliveira (laoj2)
requested a review
from Julian Gutierrez Oschmann (juli4n)
September 21, 2026 22:12
Collaborator
Author
|
Rebased |
Julian Gutierrez Oschmann (juli4n)
enabled auto-merge
September 22, 2026 20:02
* Removed maxLength requirement for in_progress_snapshot_uri to match what we have in ExternalSnapshot.snapshot_uri * Added validation for actor_template_uid * Added validation for storage_location, matching what we have in SnapshotsConfig.storage_location
worst case is storage_location (≤1024) + /atespaces/ + atespace (DNS-1123 label, ≤63) + /actors/ + UID (36) + /snapshots/ + UUID (36) = 1189. Tag snapshots are shorter still (no /snapshots/<name> tail)
Luiz Oliveira (laoj2)
force-pushed
the
tag-cleanups
branch
from
September 23, 2026 13:18
8e203db to
0df04c9
Compare
Julian Gutierrez Oschmann (juli4n)
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TagStatus.source_actor_uid is unused, we can add this back if we ever need it.
#1168
We were also missing some of the DV for TagStatus fields: