Repository navigation
Consolidate subcommands for each resource on a single file. - #1733
Merged
Merged
Conversation
Collaborator
|
What about each resource in a separate package? We should be careful if a file gets above 1kLoC |
Collaborator
Author
|
Sure, we can consider that if resources grow too much. I think we are ok for now? |
Julian Gutierrez Oschmann (juli4n)
requested a review
from Luiz Oliveira (laoj2)
September 18, 2026 12:48
Julian Gutierrez Oschmann (juli4n)
marked this pull request as ready for review
September 18, 2026 12:48
Luiz Oliveira (laoj2)
approved these changes
Sep 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the number of resources in the Substrate API grows, having one file for each (resource x verb) is becoming hard to manage. We recently started consolidating all commands for a each resource in a single file (see tag.go), similar to how we organize RPC handlers in the ate-apiserver
controlapipackage.This PR re-organizes the resources that are sill spread across multiple files.