Repository navigation
A few more changes to resource defaults - #1674
Merged
Merged
Conversation
We need to backfill defaults on read from the store, but controlapi already imports store, so store can't import controlapi's defaulting logic without a cycle. Move it to its own package so both sides can call it.
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
defaults
branch
from
September 16, 2026 16:40
9c3b1a6 to
66b1a99
Compare
This is to make sure all resources are properly defaulted, even the ones that have been created before a new field with a default was introduced.
Make path default to `/` instead of `/readyz`. Also remove the defaulting logic in ateom as the caller (ate-apiserver and atelet) will provide defaulted values now.
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
defaults
branch
from
September 16, 2026 16:48
66b1a99 to
68b77ff
Compare
Julian Gutierrez Oschmann (juli4n)
marked this pull request as ready for review
September 16, 2026 16:50
Julian Gutierrez Oschmann (juli4n)
requested a review
from Tim Hockin (thockin)
September 16, 2026 16:50
Bowei Du (bowei)
added
kind/cleanup
Zoe Zhao (zoez7)
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmd/ateapi/internal/defaults.Part of #1593