Repository navigation
Log the build version when each component starts - #1569
Merged
Jeff Luo (JeffLuoo) merged 1 commit intoSep 10, 2026
Merged
Conversation
Anna Pendleton (annapendleton)
approved these changes
Sep 10, 2026
Anna Pendleton (annapendleton)
left a comment
Anna Pendleton (annapendleton)
left a comment
Collaborator
There was a problem hiding this comment.
tysm!
Every long-running binary has --version, emit one "<component> starting" line right after the logger is up, carrying the stamped version. atecontroller also gains the --version flag it was missing.
Haven Xia (HavenXia)
force-pushed
the
version-startup-log
branch
from
September 10, 2026 17:28
30ba9ab to
ba1b6a2
Compare
|
|
||
| ateAPIConnSpec = pflag.String("ateapi-conn-spec", "k8s:///api.ate-system.svc:443", "") | ||
|
|
||
| showVersion = pflag.Bool("version", false, "Print version and exit.") |
Collaborator
There was a problem hiding this comment.
What is the use case of just logging the version and then terminate the controller?
Member
Author
There was a problem hiding this comment.
It's the exact same --version flag the other components already have (ateapi, atelet, podcertcontroller .etc). the flag was provided to allow print the version of the component.
Normal startup go through the new slog line below.
Jeff Luo (JeffLuoo)
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit one " starting" line right after the logger is up, carrying the stamped version.
atecontroller also gains the --version flag it was missing.