Repository navigation
Increase actor termination grace period to 30m - #1565
Merged
Julian Gutierrez Oschmann (juli4n) merged 2 commits intoSep 9, 2026
Merged
Julian Gutierrez Oschmann (juli4n) merged 2 commits into
Julian Gutierrez Oschmann (juli4n) merged 2 commits into
Conversation
A one-minute grace period is nowhere near enough for an actor to suspend normally, so evictions were very likely to leave actors CRASHED instead of cleanly suspended.
Scott Funkenhauser (sfunkenhauser)
marked this pull request as ready for review
September 9, 2026 18:25
Scott Funkenhauser (sfunkenhauser)
requested a review
from Julian Gutierrez Oschmann (juli4n)
September 9, 2026 18:26
| // It needs to stay significantly less than the K8s termination grace period | ||
| // for the ateom, so the escalation to SIGKILL happens here rather than as a | ||
| // kubelet SIGKILL of ateom itself. A var so tests can shorten it. | ||
| var workloadGracePeriod = 30 * time.Minute |
Collaborator
There was a problem hiding this comment.
Why switching to a var?
A var so tests can shorten it.
I don't see it being set in tests.
Collaborator
Author
There was a problem hiding this comment.
Good catch, these were left over from a previous iteration and are no longer needed. The workload / containerKillTimeout are still var so they can be overridden in the tests and save ~10s.
Julian Gutierrez Oschmann (juli4n)
approved these changes
Sep 9, 2026
Julian Gutierrez Oschmann (juli4n)
merged commit Sep 9, 2026
6730460
into
agent-substrate:main
9 checks passed
Julian Gutierrez Oschmann (juli4n)
pushed a commit
that referenced
this pull request
Sep 9, 2026
Cherry-picking #1565 - [ x ] Tests pass - [ x ] Appropriate changes to documentation are included in the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A one-minute grace period is nowhere near enough for an actor to suspend normally, so evictions were very likely to leave actors CRASHED instead of cleanly suspended.
Previously there were two 1 minute timeouts. Waiting for in-flight RPCs to finish, and then another for SIGTERM. With such a short termination grace period the in-flight RPC could have eaten a significant portion of the timeout leaving very little for the actor.
With a longer timeout this is less of a concern, and has now been collapsed into a single deadline for both operations.
Fixes #1560