Repository navigation
Remove the top level --boot flag from ResumeActorRequest - #1548
Merged
Julian Gutierrez Oschmann (juli4n) merged 1 commit intoSep 11, 2026
Merged
Conversation
Zoe Zhao (zoez7)
requested review from
Julian Gutierrez Oschmann (juli4n) and
Max Smythe (maxsmythe)
September 9, 2026 00:14
Zoe Zhao (zoez7)
marked this pull request as ready for review
September 9, 2026 00:14
Collaborator
|
This seems like it may actually be a different kind of bug... what happens when a snapshot with durdir gets into a permanently bad state (crashed)? What are the options for reading only the persisted data? Otherwise, if this is never an expected action, I see no reason to benchmark it other than catching the edge case where there is no golden snapshot (which could still be interesting). |
Collaborator
Author
This is the API being discussed in #1556 |
Julian Gutierrez Oschmann (juli4n)
previously approved these changes
Sep 11, 2026
Julian Gutierrez Oschmann (juli4n)
left a comment
Collaborator
There was a problem hiding this comment.
Needs rebase.
Zoe Zhao (zoez7)
force-pushed
the
resume-boot
branch
from
September 11, 2026 17:30
05266d2 to
b3e719b
Compare
Resume resolves its restore source in strict priority order: the actor's node-local snapshot, then its own durable external snapshot, then the template's golden snapshot, then a cold boot from the template spec. The boot flag was consulted at exactly one point in that chain, where it suppressed the golden-snapshot fallback, which made its behavior much narrower than "boot from scratch" suggests: - Actor has its own external snapshot, boot=true: flag ignored, restores the actor's snapshot. - Actor has a local snapshot, boot=true: flag ignored, restores the local snapshot. - Actor has no snapshot, template has a golden snapshot: boot=false restores the golden, boot=true cold boots from the spec. The only case the flag ever changed. - Actor has no snapshot, template has no golden snapshot: cold boot from the spec regardless of the flag. The one behavior the flag still controlled is not worth a public API field: when a template has no golden snapshot, the golden actor is cold booted from the template spec anyway, so the cold-boot path remains exercised without a caller-facing escape hatch. The flag was silently ignored in every other state, no caller outside the glutton benchmark ever set it, and no test covered boot=true. The glutton benchmark was the only caller that set boot=true, on each actor's first resume, to report true cold-start latency as a separate ResumeActorColdStart stats row. That row is renamed to ResumeActorFirstResume: a fresh actor's first resume now restores the template's golden snapshot instead of cold booting, so the old name would misrepresent what it measures. The proto field number and name are reserved per convention.
Zoe Zhao (zoez7)
force-pushed
the
resume-boot
branch
from
September 11, 2026 21:21
b3e719b to
8048ba3
Compare
Julian Gutierrez Oschmann (juli4n)
merged commit Sep 11, 2026
a536fab
into
agent-substrate:main
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1566
Today the Resume workflow resolves its restore source in the following order
The boot flag was consulted at exactly one point in that chain, where it suppressed using the golden-snapshot, which made its behavior much narrower than "boot from scratch" suggests:
The glutton benchmark was the only caller that set boot=true, on each actor's first resume, to report true cold-start latency as a separate ResumeActorColdStart stats row. Max Smythe (@maxsmythe) let me know if this is required.
The proto field number and name were reserved.