Skip to content

Add e2e test coverage for non-HTTP egress traffic #1017

Open

Description

@haiyanmeng

https://github.com/agent-substrate/substrate/blob/9bfc67e8159993fce4f120e3a561a7ee61495959/internal/e2e/suites/networking/networking_test.go has test coverage for HTTP and HTTPS traffic: TestActorEgress and TestActorEgressHTTPS.

We should add e2e test coverage for non-HTTP traffic, such as running git clone [email protected]:agent-substrate/substrate.git from an actor.

The test coverage gap was identified during the review process of #871.

cc Bowei Du (@bowei) Lior Lieberman (@LiorLieberman)

Activity

  1. self-assigned this
    on Aug 17, 2026
  2. added theissue type on Aug 17, 2026
  3. haiyanmeng commented on Aug 18, 2026

    @haiyanmeng
    CollaboratorAuthor

    #1024 adds test coverage for SSH traffic

    I plan to add e2e test coverage for WebSockets and SSE today.

    Are there other types of traffic we need to cover? Bowei Du (@bowei) Lior Lieberman (@LiorLieberman)

  4. bowei commented on Aug 18, 2026

    @bowei
    Collaborator

    We can add to fill out the matrix. I do not expect everything to pass:

    (All HTTP variants should be tested with HTTP/1.1, HTTP/2, HTTP/3)
    (All protocols should be tested against IPv4, IPv6)

  5. haiyanmeng commented on Aug 25, 2026

    @haiyanmeng
    CollaboratorAuthor

    Yufan Su (@yufan-su) , I am going to work on the test coverage for raw TCP and SSH traffic next.

    Can you add test coverage for HTTPS/1.1 on non-443 port, HTTP upgrade to WebSocket, and HTTPS upgrade to WebSocket?

  6. changed the title [-]Add e2e test coverage for non-HTTP traffic[/-] [+]Add e2e test coverage for non-HTTP egress traffic[/+] on Aug 25, 2026
  7. haiyanmeng commented on Sep 13, 2026

    @haiyanmeng
    CollaboratorAuthor

    Adhita Selvaraj (@swiftdiaries) , do you want to pick up the work of adding test coverage for HTTPS/1.1 on non-443 port, HTTP upgrade to WebSocket, and HTTPS upgrade to WebSocket? One example to look into is TestActorEgressNonStandardPort. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area/networkkind/featureAn enhancement / feature request or implementation

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions