Skip to content

Commit b8be927

Browse files
committed
Give the boot-fetch probe template explicit limits
Nothing substitutes ${TEMPLATE_RESOURCES} or ${TEMPLATE_SANDBOX_CONFIG}, so ko resolve failed on the rendered template. Render it with the other fixture templates so a stray placeholder fails a unit test.
1 parent 274008a commit b8be927

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

‎internal/e2e/fixtures/probe/probe-bootfetch-template.yaml.tmpl‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,9 @@ volumes:
5252
- field: ACTOR_METADATA_FIELD_NAME
5353
path: actor-id
5454
${TEMPLATE_TRUST_BUNDLE}
55-
${TEMPLATE_RESOURCES}
56-
${TEMPLATE_SANDBOX_CONFIG}
55+
resources:
56+
limits:
57+
cpuMillicores: 1000
58+
memoryBytes: 536870912 # 512Mi
5759
snapshotConfig:
58-
storageLocation: gs://${BUCKET_NAME}/ate-e2e-probe${FIXTURE_SUFFIX}-bootfetch/
60+
storageLocation: gs://${BUCKET_NAME}/ate-e2e-probe-bootfetch${FIXTURE_SUFFIX}/

‎internal/e2e/sandbox_test.go‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ var substrateFixtures = []struct {
3636
Pool: "internal/e2e/fixtures/probe/probe.yaml.tmpl",
3737
Template: "internal/e2e/fixtures/probe/probe-template.yaml.tmpl",
3838
}, 1},
39+
{SubstrateFixtureManifests{
40+
Pool: "internal/e2e/fixtures/probe/probe.yaml.tmpl",
41+
Template: "internal/e2e/fixtures/probe/probe-bootfetch-template.yaml.tmpl",
42+
}, 1},
3943
{SubstrateFixtureManifests{
4044
Pool: "internal/e2e/fixtures/probe/probe-sized.yaml.tmpl",
4145
Template: "internal/e2e/fixtures/probe/probe-sized-template.yaml.tmpl",

0 commit comments

Comments
 (0)