Repository navigation
Commit a5b1804
committed
Address review comments on WorkerPool SandboxConfig resolution
- Rename the WorkerPool cache index to status.sandboxClasses.sandboxConfig.
It indexes pendingConfigRef as well as configRef, so a name that mentions
only configRef misleads a reader checking why a claimed config is in use.
- List pendingConfigRef in the api-guide's status table, so the row matches
the schema instead of leaving the field to the Deletion protection section.
- Say that the pool's events are its recent history. The API server drops
events after their TTL, one hour by default, so only a logging backend
that stores events has the full trail.1 parent b9439d0 commit a5b1804
3 files changed
Lines changed: 7 additions & 5 deletions
File tree
- cmd/atecontroller/internal/controllers
- docs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
278 | 278 | | |
279 | 279 | | |
280 | 280 | | |
281 | | - | |
282 | | - | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
283 | 284 | | |
284 | 285 | | |
285 | 286 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
| 112 | + | |
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| |||
0 commit comments