Skip to content

Commit 968aee5

Browse files
committed
test: accept a readback timeout in the normalization mismatch test
The last poll of the editable text readback can start just before the one-second deadline and still be reading when it passes, which reports ReadbackTimedOut instead of MismatchAfterDeadline. A slow CI runner hit this. The two other mismatch tests already accept both outcomes, since both leave the write unverified and neither allows a replay.
1 parent 2f1e32d commit 968aee5

2 files changed

Lines changed: 14 additions & 1 deletion

File tree

‎CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10+
### Fixed
11+
12+
- The `editable_text_normalization_mismatch_is_not_verified` test accepts `ReadbackTimedOut` as well as `MismatchAfterDeadline`, like the two other mismatch tests. Its last poll can start just before the one-second deadline and still be reading when it passes. On a slow CI runner the test failed this way. Both outcomes leave the write unverified, and neither allows a replay.
13+
1014
## [0.7.47] - 2026-11-05
1115

1216
### Fixed

‎src/atspi_tree.rs‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2225,7 +2225,16 @@ mod tests {
22252225
.unwrap(),
22262226
);
22272227

2228-
assert_eq!(outcome, EditableTextSetOutcome::MismatchAfterDeadline);
2228+
// A last poll can cross the same fixed deadline. Both outcomes mean
2229+
// an unverified write; neither permits verification or replay.
2230+
assert!(
2231+
matches!(
2232+
outcome,
2233+
EditableTextSetOutcome::MismatchAfterDeadline
2234+
| EditableTextSetOutcome::ReadbackTimedOut
2235+
),
2236+
"{outcome:?}"
2237+
);
22292238
let state = state.lock().unwrap();
22302239
assert_eq!(state.mutations, 1);
22312240
assert!(state.character_count_reads > 1);

0 commit comments

Comments
 (0)