fix: update hardcoded repo path in download URLs#676
Conversation
…x in download URLs
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the repository path from avifenesh/agnix to agent-sh/agnix across the project, including JetBrains and VS Code extensions, NPM scripts, and shell scripts. The review feedback suggests improving maintainability by replacing hardcoded repository strings in test files with constants or existing configuration values.
editors/jetbrains/src/test/kotlin/io/agnix/jetbrains/binary/AgnixBinaryDownloaderTest.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Updates hardcoded GitHub repository owner/name used to construct release asset download URLs after transferring the repo from avifenesh/agnix to agent-sh/agnix, ensuring downloads don’t 404 due to non-followed redirects on release assets.
Changes:
- Updated hardcoded repo path in download/install code paths (shell script, npm installer, VS Code extension, JetBrains plugin).
- Updated CI workflow release-check API URL to point at the new repo.
- Updated unit tests to match the new expected GitHub release URL format, and added an Unreleased changelog entry.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/download.sh |
Updates REPO used to build release asset download URLs. |
npm/install.js |
Updates GITHUB_REPO for npm postinstall download logic. |
editors/vscode/src/extension.ts |
Updates GITHUB_REPO used by the VS Code extension download/version logic. |
editors/vscode/src/test/unit/versionCheck.test.ts |
Updates expected release URL strings in unit tests. |
editors/jetbrains/src/main/kotlin/io/agnix/jetbrains/binary/AgnixBinaryDownloader.kt |
Updates GITHUB_REPO used by the JetBrains binary downloader. |
editors/jetbrains/src/test/kotlin/io/agnix/jetbrains/binary/AgnixBinaryDownloaderTest.kt |
Updates URL expectations in downloader trust/redirect tests. |
.github/workflows/test-action.yml |
Updates GitHub API URL used to resolve latest release tag in CI. |
CHANGELOG.md |
Adds an Unreleased “Fixed” entry documenting the repo-path update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ### Fixed | ||
| - **Download URLs**: Updated hardcoded repository path from `avifenesh/agnix` to `agent-sh/agnix` across download scripts, editor extensions, and CI workflows (#676). | ||
|
|
There was a problem hiding this comment.
The PR description says "Files changed (7)", but this PR also modifies CHANGELOG.md (making 8 files). Consider updating the PR description summary/table so it matches the actual changed file list.
| ## [Unreleased] | ||
|
|
||
| ### Fixed | ||
| - **Download URLs**: Updated hardcoded repository path from `avifenesh/agnix` to `agent-sh/agnix` across download scripts, editor extensions, and CI workflows (#676). |
There was a problem hiding this comment.
This changelog bullet says the repo path update happened across "CI workflows", but the PR only updates a single workflow file (.github/workflows/test-action.yml). Consider changing the wording to "CI workflow" (singular) or explicitly listing the affected workflow(s) to keep the changelog accurate.
| - **Download URLs**: Updated hardcoded repository path from `avifenesh/agnix` to `agent-sh/agnix` across download scripts, editor extensions, and CI workflows (#676). | |
| - **Download URLs**: Updated hardcoded repository path from `avifenesh/agnix` to `agent-sh/agnix` across download scripts, editor extensions, and the `test-action` CI workflow (`.github/workflows/test-action.yml`) (#676). |
Summary
The repo was transferred from
avifenesh/agnixtoagent-sh/agnix. GitHub handles redirects fine for web pages and API calls, but release asset download URLs do NOT follow 301 redirects — they return 404.This fixes all code paths that construct download URLs using a hardcoded
avifenesh/agnixowner/repo path.Files changed (7)
scripts/download.shREPOvariable.github/workflows/test-action.ymleditors/vscode/src/extension.tsGITHUB_REPOconsteditors/vscode/src/test/unit/versionCheck.test.tseditors/jetbrains/.../AgnixBinaryDownloader.ktGITHUB_REPOconsteditors/jetbrains/.../AgnixBinaryDownloaderTest.ktnpm/install.jsGITHUB_REPOconstNot changed (intentional)
website/versioned docs — historical referencesCargo.toml— cosmetic fields, redirects workplugin.xml,package.json— web URLs, not download URL constructionextension.tsline 694 brew tap — display string onlyTest plan
scripts/download.shfetches release assets fromagent-sh/agnix