fix: normalize paths for exclude glob matching (#67) by avifenesh · Pull Request #123 · agent-sh/agnix

avifenesh · 2026-02-03T10:42:07Z

Summary

Fixed bug where exclude glob patterns (e.g., target/**) failed to match when validate_project() was called with absolute paths
Added path normalization using strip_prefix(path) to convert absolute entry paths to relative before glob matching
Added 3 comprehensive tests for absolute paths, relative paths, and nested directories

Test Plan

All 663 existing tests pass
New tests verify fix with absolute and relative paths
cargo clippy passes with no warnings
Release build succeeds

Related Issues

Closes #67

When validate_project() is called with an absolute path, the walker produces absolute entry paths that fail to match relative exclude patterns like `target/**`. Fix by stripping the base path prefix before glob matching.

gemini-code-assist · 2026-02-03T10:43:18Z

Summary of Changes

Hello @avifenesh, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug that prevented exclude glob patterns from working correctly with absolute paths. It introduces path normalization to ensure accurate glob matching and includes new tests to verify the fix.

Highlights

Bug Fix: Addresses an issue where exclude glob patterns failed to match when validate_project() was called with absolute paths.
Path Normalization: Implements path normalization using strip_prefix(path) to convert absolute entry paths to relative paths before glob matching.
Testing: Includes 3 new tests to ensure correct behavior with absolute paths, relative paths, and nested directories.

Changelog

CHANGELOG.md
- Added a note about the fix for exclude glob patterns matching with absolute paths.
- Mentioned the path normalization by stripping base path prefix before glob matching.
crates/agnix-core/src/lib.rs
- Implemented path normalization using strip_prefix(path) to convert absolute entry paths to relative paths before glob matching.

Activity

The PR author, avifenesh, has addressed issue Fix exclude glob matching when walker yields absolute paths #67 by fixing a bug related to exclude glob patterns.
The changes include path normalization and new tests for absolute and relative paths.
All existing tests pass, and new tests verify the fix.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 340c184ea1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/agnix-core/src/lib.rs

gemini-code-assist

Code Review

This pull request correctly identifies and fixes a bug where exclude glob patterns failed on absolute paths. The approach of stripping the base path prefix is sound, and the added tests are comprehensive, covering absolute, relative, and nested directory scenarios. The identified area for improvement regarding path normalization remains valid and will make the solution more robust and cross-platform compatible.

claude · 2026-02-03T10:47:22Z

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Copilot

Pull request overview

This PR fixes a bug where exclude glob patterns (e.g., target/**) failed to match files when validate_project() was called with absolute paths. The fix normalizes entry paths to relative paths before glob matching by using strip_prefix() to remove the base path.

Changes:

Added path normalization in validate_project_with_registry() to convert absolute entry paths to relative before glob matching
Added 3 comprehensive tests covering absolute paths, relative paths, and nested directories
Updated CHANGELOG.md to document the fix

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crates/agnix-core/src/lib.rs	Implements path normalization using `strip_prefix()` before glob matching and adds three comprehensive tests for exclude pattern behavior
CHANGELOG.md	Documents the bug fix for exclude glob pattern matching with absolute paths

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/agnix-core/src/lib.rs

- Remove non-standard `version` field from SKILL.md frontmatter (fixes code scanning alert #1062, XP-SK-001) - Override serialize-javascript to ^7.0.5 in website and vscode extension to fix CPU exhaustion DoS vulnerability (fixes Dependabot alerts #122 and #123)

* fix: resolve security alerts (serialize-javascript, XP-SK-001) - Remove non-standard `version` field from SKILL.md frontmatter (fixes code scanning alert #1062, XP-SK-001) - Override serialize-javascript to ^7.0.5 in website and vscode extension to fix CPU exhaustion DoS vulnerability (fixes Dependabot alerts #122 and #123) * fix: address review feedback - add engines.node, changelog entry - Add engines.node >= 20.0.0 to website and vscode extension (serialize-javascript@7 requires Node 20+) - Add CHANGELOG.md entry for security fixes * fix: merge engines.node into existing engines block Avoid overwriting engines.vscode by merging the Node constraint into the existing engines object instead of adding a duplicate key. * fix: merge duplicate Fixed headings in changelog

avifenesh added 2 commits February 3, 2026 12:32

fix: normalize paths for exclude glob matching (#67)

d744856

When validate_project() is called with an absolute path, the walker produces absolute entry paths that fail to match relative exclude patterns like `target/**`. Fix by stripping the base path prefix before glob matching.

docs: add changelog entry for exclude glob fix (#67)

340c184

Copilot AI review requested due to automatic review settings February 3, 2026 10:42

Copilot started reviewing on behalf of avifenesh February 3, 2026 10:42 View session

chatgpt-codex-connector bot reviewed Feb 3, 2026

View reviewed changes

crates/agnix-core/src/lib.rs Show resolved Hide resolved

gemini-code-assist bot reviewed Feb 3, 2026

View reviewed changes

Copilot AI reviewed Feb 3, 2026

View reviewed changes

crates/agnix-core/src/lib.rs Outdated Show resolved Hide resolved

fix: address review feedback - clarify test comment

a3754e7

avifenesh merged commit a0278c9 into main Feb 3, 2026
12 checks passed

avifenesh deleted the fix/exclude-glob-67 branch February 3, 2026 10:56

avifenesh mentioned this pull request Feb 3, 2026

Fix exclude pattern matching to use relative paths #82

Closed

avifenesh mentioned this pull request Mar 28, 2026

fix: resolve security alerts (serialize-javascript, XP-SK-001) #693

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: normalize paths for exclude glob matching (#67)#123

fix: normalize paths for exclude glob matching (#67)#123
avifenesh merged 3 commits intomainfrom
fix/exclude-glob-67

avifenesh commented Feb 3, 2026

Uh oh!

gemini-code-assist bot commented Feb 3, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

claude bot commented Feb 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

avifenesh commented Feb 3, 2026

Summary

Test Plan

Related Issues

Uh oh!

gemini-code-assist bot commented Feb 3, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

claude bot commented Feb 3, 2026

Code review

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants