#15 Fix double keystroke bug in Windows#82
Merged
agavra merged 1 commit intoagavra:mainfrom Jan 14, 2026
Merged
Conversation
Added a check for KeyEventKind::Press to ensure that only key press events are processed, since Windows also sends KeyEventKind::Release, which will results in another keystroke.
There was a problem hiding this comment.
Pull request overview
This PR fixes a Windows-specific bug where keystrokes were being registered twice due to both key press and key release events being processed.
Changes:
- Added
KeyEventKindimport from crossterm's event module - Added a filter to process only
KeyEventKind::Pressevents in the main event loop
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
agavra
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a check for KeyEventKind::Press to ensure that only key press events are processed, since Windows also sends KeyEventKind::Release, which will results in another keystroke.
fixes #15