fix(input): support Shift+Tab reverse cycling#213
Merged
agavra merged 3 commits intoagavra:mainfrom Mar 20, 2026
Merged
Conversation
agavra
reviewed
Mar 18, 2026
| }; | ||
| } | ||
|
|
||
| pub fn cycle_comment_type_reverse(&mut self) { |
Owner
There was a problem hiding this comment.
Does this work with #211? I feel like it should be generic ordering
Contributor
Author
There was a problem hiding this comment.
Good catch, updated. now uses the same generic ordering as forward Tab cycling, so it works correctly with configurable comment types from #211.
Contributor
Author
There was a problem hiding this comment.
Updated with generic ordering: reverse cycling now resolves current type index from the configured comment_types list and wraps to the last entry when needed (same model as forward Tab cycling).
villads-valur
force-pushed
the
fix/upstream-shift-tab-reverse-cycling
branch
from
7018812 to
27c5877
Compare
agavra
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shift+Tab(BackTab) support to reverse cycle comment types in Comment mode.Shift+Tabreverse focus traversal in Normal mode to complement existing forwardTabfocus cycling.Testing
cargo fmt --allcargo test input::keybindings::testscargo check