Skip to content

feat(config): customizable comment types with labels, colors and definitions#211

Merged
agavra merged 3 commits intoagavra:mainfrom
villads-valur:feature/upstream-comment-types-config
Mar 18, 2026
Merged

feat(config): customizable comment types with labels, colors and definitions#211
agavra merged 3 commits intoagavra:mainfrom
villads-valur:feature/upstream-comment-types-config

Conversation

@villads-valur
Copy link
Copy Markdown
Contributor

@villads-valur villads-valur commented Mar 17, 2026 •
edited
Loading

Summary

  • add comment_types config support as an inline array of objects with replace semantics
  • allow custom comment type id, label, color, and definition, including dynamic Tab cycling and UI rendering
  • update markdown export so type legend carries configured definitions and comment tags use configured labels

Validation

  • cargo test
  • cargo build --release

@villads-valur villads-valur marked this pull request as ready for review March 17, 2026 10:47
agavra
agavra approved these changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Owner

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @villads-valur - I like this feature a lot, I'll probably end up using it with just comment/nitpick (I ahven't found much value in the individual types, but if anyone else has suggestions going forward that'll be fun to try out)

@villads-valur
Copy link
Copy Markdown
Contributor Author

villads-valur commented Mar 18, 2026 •
edited
Loading

@agavra Addressed this nit now 👍 Updated the README review-output example to show default comment types, and added a note that both the legend and tags are config-driven when is set.

I like this idea of putting more customizations in the config, I have a couple of ideas more on going this direction - what's your thoughts on this?

@agavra
Copy link
Copy Markdown
Owner

agavra commented Mar 18, 2026

I like this idea of putting more customizations in the config, I have a couple of ideas more on going this direction - what's your thoughts on this?

I'm on board so long as they aren't required!

@agavra agavra merged commit 47bf47a into agavra:main Mar 18, 2026
4 checks passed
@agavra agavra mentioned this pull request Mar 18, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agavra agavra agavra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@villads-valur @agavra